Skip to content

Ref: comment out setAttribute from scope sync. #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lucas-zimerman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ref: comment out setAttribute from scope sync. #5612

lucas-zimerman wants to merge 2 commits into from
+25 −14

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Feb 3, 2026 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

At the moment, both native implementations have no code, they are just empty functions, so lets temporarily remove the scope code and also add a warning in case some user uses this feature and wonders why it's not working.

💡 Motivation and Context

I though for a moment the feature was working since I saw the setAttributes being exposed on scope and also on the scope sync. Turned out the native code wasn't doing anything in regard to setAttributes.

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026 •
edited
Loading

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

  • Ref: comment out setAttribute from scope sync. by lucas-zimerman in #5612
  • Expo Router integration improvement: Prefetch route performance measurement with automatically created spans by alwx in #5606
  • chore(deps): update Bundler Plugins to v4.9.0 by github-actions in #5608
  • e2e tests on Cirrus Labs runners by alwx in #5485
  • chore(deps): bump getsentry/craft from 2.20.0 to 2.20.1 by dependabot in #5603
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.20.0 to 2.20.1 by dependabot in #5604
  • chore(deps): bump github/codeql-action from 4.31.11 to 4.32.0 by dependabot in #5605
  • Ref: Add Claude task by lucas-zimerman in #5602
  • chore(deps): update JavaScript SDK to v10.38.0 by github-actions in #5596

🤖 This preview updates automatically when you update the PR.

@lucas-zimerman lucas-zimerman added the ready-to-merge Triggers the full CI test suite label Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.33 ms 1222.30 ms -1.03 ms
Size 3.38 MiB 4.60 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
55b77fc+dirty 1223.71 ms 1224.12 ms 0.41 ms
8d20c8e+dirty 1216.62 ms 1220.31 ms 3.69 ms
df1f7df+dirty 1219.21 ms 1224.28 ms 5.07 ms
60cd796+dirty 1204.87 ms 1202.71 ms -2.17 ms
f70acbf+dirty 1235.71 ms 1243.14 ms 7.43 ms
bfe454a+dirty 1235.33 ms 1243.12 ms 7.79 ms
fa7bb7e+dirty 1216.23 ms 1225.04 ms 8.81 ms
3099014+dirty 1226.75 ms 1236.56 ms 9.81 ms
b80b14f+dirty 1212.62 ms 1211.73 ms -0.89 ms
ad27f6e+dirty 1223.41 ms 1246.29 ms 22.88 ms

App size

Revision Plain With Sentry Diff
55b77fc+dirty 3.41 MiB 4.58 MiB 1.17 MiB
8d20c8e+dirty 3.41 MiB 4.57 MiB 1.16 MiB
df1f7df+dirty 3.44 MiB 4.59 MiB 1.15 MiB
60cd796+dirty 3.44 MiB 4.67 MiB 1.23 MiB
f70acbf+dirty 2.63 MiB 3.98 MiB 1.34 MiB
bfe454a+dirty 2.63 MiB 3.98 MiB 1.34 MiB
fa7bb7e+dirty 2.63 MiB 4.01 MiB 1.38 MiB
3099014+dirty 2.63 MiB 3.98 MiB 1.35 MiB
b80b14f+dirty 3.41 MiB 4.59 MiB 1.18 MiB
ad27f6e+dirty 3.41 MiB 4.67 MiB 1.25 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 469.35 ms 493.76 ms 24.41 ms
Size 43.75 MiB 48.41 MiB 4.66 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
11ded16+dirty 317.29 ms 329.15 ms 11.86 ms
d1fd647+dirty 413.02 ms 459.72 ms 46.70 ms
9bf5446+dirty 442.47 ms 452.14 ms 9.67 ms
0d6e618+dirty 414.00 ms 416.90 ms 2.90 ms
5526494 440.84 ms 448.36 ms 7.52 ms
3bd3f0d+dirty 447.21 ms 472.31 ms 25.10 ms
6bb8427+dirty 360.48 ms 400.04 ms 39.56 ms
bb4ea33+dirty 416.47 ms 424.56 ms 8.09 ms
cdf7e97+dirty 459.49 ms 495.10 ms 35.61 ms
e07935d+dirty 448.82 ms 489.10 ms 40.29 ms

App size

Revision Plain With Sentry Diff
11ded16+dirty 17.75 MiB 19.75 MiB 2.00 MiB
d1fd647+dirty 17.75 MiB 19.70 MiB 1.95 MiB
9bf5446+dirty 43.75 MiB 48.04 MiB 4.29 MiB
0d6e618+dirty 43.75 MiB 47.99 MiB 4.24 MiB
5526494 17.75 MiB 19.68 MiB 1.93 MiB
3bd3f0d+dirty 17.75 MiB 19.70 MiB 1.95 MiB
6bb8427+dirty 43.75 MiB 48.08 MiB 4.33 MiB
bb4ea33+dirty 43.75 MiB 48.08 MiB 4.33 MiB
cdf7e97+dirty 43.75 MiB 48.40 MiB 4.64 MiB
e07935d+dirty 43.75 MiB 47.99 MiB 4.24 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.52 ms 1214.35 ms 1.83 ms
Size 3.38 MiB 4.60 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
55b77fc+dirty 1213.08 ms 1218.19 ms 5.11 ms
8d20c8e+dirty 1223.60 ms 1223.87 ms 0.27 ms
df1f7df+dirty 1217.00 ms 1213.27 ms -3.73 ms
60cd796+dirty 1206.08 ms 1213.36 ms 7.28 ms
f70acbf+dirty 1239.00 ms 1242.53 ms 3.53 ms
bfe454a+dirty 1231.82 ms 1239.98 ms 8.16 ms
fa7bb7e+dirty 1226.27 ms 1241.88 ms 15.61 ms
3099014+dirty 1234.04 ms 1243.22 ms 9.18 ms
b80b14f+dirty 1193.79 ms 1199.12 ms 5.33 ms
ad27f6e+dirty 1214.28 ms 1203.67 ms -10.62 ms

App size

Revision Plain With Sentry Diff
55b77fc+dirty 3.41 MiB 4.58 MiB 1.17 MiB
8d20c8e+dirty 3.41 MiB 4.57 MiB 1.16 MiB
df1f7df+dirty 3.44 MiB 4.59 MiB 1.15 MiB
60cd796+dirty 3.44 MiB 4.67 MiB 1.23 MiB
f70acbf+dirty 3.19 MiB 4.54 MiB 1.36 MiB
bfe454a+dirty 3.19 MiB 4.54 MiB 1.36 MiB
fa7bb7e+dirty 3.19 MiB 4.58 MiB 1.39 MiB
3099014+dirty 3.19 MiB 4.55 MiB 1.36 MiB
b80b14f+dirty 3.41 MiB 4.59 MiB 1.18 MiB
ad27f6e+dirty 3.41 MiB 4.67 MiB 1.25 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 565.92 ms 598.31 ms 32.39 ms
Size 43.94 MiB 49.27 MiB 5.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5526494+dirty 380.79 ms 432.70 ms 51.91 ms
ba75c7c+dirty 377.92 ms 417.74 ms 39.83 ms
f234eb4+dirty 313.23 ms 333.31 ms 20.08 ms
9bf5446+dirty 423.53 ms 461.73 ms 38.20 ms
0b64753+dirty 358.55 ms 429.16 ms 70.61 ms
0d6e618+dirty 369.02 ms 387.69 ms 18.67 ms
6bb8427+dirty 393.25 ms 414.96 ms 21.71 ms
bb4ea33+dirty 360.73 ms 375.02 ms 14.29 ms
cdf7e97+dirty 389.79 ms 418.13 ms 28.34 ms
20d5eaa+dirty 358.31 ms 442.37 ms 84.06 ms

App size

Revision Plain With Sentry Diff
5526494+dirty 7.15 MiB 8.41 MiB 1.26 MiB
ba75c7c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
f234eb4+dirty 7.15 MiB 8.46 MiB 1.30 MiB
9bf5446+dirty 43.94 MiB 48.87 MiB 4.93 MiB
0b64753+dirty 7.15 MiB 8.42 MiB 1.27 MiB
0d6e618+dirty 43.94 MiB 48.82 MiB 4.88 MiB
6bb8427+dirty 43.94 MiB 48.91 MiB 4.97 MiB
bb4ea33+dirty 43.94 MiB 48.91 MiB 4.97 MiB
cdf7e97+dirty 43.94 MiB 49.22 MiB 5.29 MiB
20d5eaa+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx Awaiting requested review from alwx alwx is a code owner

@antonis antonis Awaiting requested review from antonis antonis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucas-zimerman