Skip to content

Ref: comment out setAttribute from scope sync. #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-zimerman merged 2 commits into from
Feb 4, 2026
+25 −14
Merged

Ref: comment out setAttribute from scope sync. #5612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e825f0d
comment setAttribute scope and add warn log
lucas-zimerman Feb 3, 2026
b4b0a2e
lint fix
lucas-zimerman Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions packages/core/src/js/scopeSync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { Breadcrumb, Scope } from '@sentry/core';
import { debug } from '@sentry/core';
import { logger } from '@sentry/react';
import { DEFAULT_BREADCRUMB_LEVEL } from './breadcrumb';
import { fillTyped } from './utils/fill';
Expand Down Expand Up @@ -81,26 +82,30 @@ export function enableSyncToNative(scope: Scope): void {
});

fillTyped(scope, 'setAttribute', original => (key: string, value: unknown): Scope => {
debug.warn('This feature is currently not supported.');
// Only sync primitive types
if (typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean') {
NATIVE.setAttribute(key, value);
}
// Native layer still not supported
// if (typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean') {
// NATIVE.setAttribute(key, value);
// }
return original.call(scope, key, value);
});

fillTyped(scope, 'setAttributes', original => (attributes: Record<string, unknown>): Scope => {
// Native layer not supported
debug.warn('This feature is currently not supported.');
// Filter to only primitive types
const primitiveAttrs: Record<string, string | number | boolean> = {};
Object.keys(attributes).forEach(key => {
const value = attributes[key];
if (typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean') {
primitiveAttrs[key] = value;
}
});

if (Object.keys(primitiveAttrs).length > 0) {
NATIVE.setAttributes(primitiveAttrs);
}
// const primitiveAttrs: Record<string, string | number | boolean> = {};
// Object.keys(attributes).forEach(key => {
// const value = attributes[key];
// if (typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean') {
// primitiveAttrs[key] = value;
// }
// });
//
// if (Object.keys(primitiveAttrs).length > 0) {
// NATIVE.setAttributes(primitiveAttrs);
// }
return original.call(scope, attributes);
});
}
6 changes: 6 additions & 0 deletions packages/core/test/scopeSync.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,11 @@ describe('ScopeSync', () => {
let setExtrasScopeSpy: jest.SpyInstance;
let addBreadcrumbScopeSpy: jest.SpyInstance;
let setContextScopeSpy: jest.SpyInstance;
/*
TODO: Uncomment once Native setattribute is implemented.
let setAttributeScopeSpy: jest.SpyInstance;
let setAttributesScopeSpy: jest.SpyInstance;
*/

beforeAll(() => {
const testScope = SentryCore.getIsolationScope();
Expand Down Expand Up @@ -219,6 +222,8 @@ describe('ScopeSync', () => {
expect(setContextScopeSpy).toHaveBeenCalledExactlyOnceWith('key', { key: 'value' });
});

/*
TODO: uncomment tests once native implementation is done.
it('setAttribute', () => {
expect(SentryCore.getIsolationScope().setAttribute).not.toBe(setAttributeScopeSpy);

Expand Down Expand Up @@ -283,5 +288,6 @@ describe('ScopeSync', () => {
});
expect(NATIVE.setAttributes).not.toHaveBeenCalled();
});
*/
});
});
Loading