chore(ACI): Remove installation uuid from RPC method#107982
Closed
chore(ACI): Remove installation uuid from RPC method#107982
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
ceorourke
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…p_id" This reverts commit 5ceb8ea.
ceorourke
changed the title
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Aci
Admin
Agent
Agents
Ai Conversations
Ai Insights
Autofix
Autopilot
Billing
Cells
Code Review
Conversations
Copilot
Core
Crons Detector Schedule Preview
Dashboards
Dynamic Grouping
Dynamic Sampling
Eco
Explore
Grouping
Infra
Integrations
Issue Details
Issues
Js Loader
Lint
Llm Detection
Notifications
Oauth
Objectstore
Occurrences On Eap
Onboarding
Preprod
Replay
Replays
Search Agent
Seer
Seer Explorer
Sentry Apps
Settings
Spans
Spans Buffer
Toolbar
Trace
Tracemetrics
Ui
Uptime
Uptime Assertion Failure Data
Webhook
Other
Bug Fixes 🐛Aci
Agent Insights
Agents
Ai Conversations
Ai Insights
Alerts
Auth
Autofix
Autopilot
Billing
Cells
Code Mappings
Code Review
Codeowners
Cursor
Dashboards
Data Forwarding
Eap
Explore
Explorer
Forms
Github Copilot
Grouping
Infra
Insights
Issue Details
Issues
Lint
Logs
Notifications
Onboarding
Preprod
Releases
Replay
Seer
Settings
Span Buffer
Spans Migration
Stories
Tests
Top Issues
Trace Waterfall
Tracemetrics
Typing
Ui
Uptime
Users
Other
Documentation 📚
Internal Changes 🔧Aci
Agent
Agents
Alerts
Api
Autofix
Autopilot
Billing
Cells
Code Review
Code Review
Codeowners
Conversations
Cross Event
Dashboards
Deps
Dynamic Sampling
Eslint
Explorer
Forms
Grouping
Infra
Insights
Integrations
Issues
Llm Detection
Open Periods
Ownership
Preprod
Promotions
Relay
Replay
Routes
Scraps
Seer
Sentry Apps
Slack
Span Buffer
Spans
Stories
Tests
Theme
Tracemetrics
Ui
Uptime
Workflow Engine
Other
Other
Plus 102 more 🤖 This preview updates automatically when you update the PR. |
GabeVillalobos
requested changes
Feb 12, 2026
Comment on lines
+55
to
+56
| organization_id: int, | ||
| sentry_app_id: int, |
Member
There was a problem hiding this comment.
This should probably be a new RPC method versus an in-place replacement. Additionally, we probably want to phase this out in 3 parts:
- Merge the new
update_action_status_for_sentry_app_installation__regiondefinition - Update the outbox receiver to use the new method after 1 has deployed
- Remove the old, unused call.
Reason being, when this deploys to DE or US as-is, control will continue to send old update_action_status_for_sentry_app_via_uuid__region method calls which are no longer available in region, causing a bunch of failures, and dropped action cleanups a backlog of outboxes while this continues to fail.
ceorourke
added a commit
that referenced
this pull request
Feb 12, 2026
…nstallation deletion (#108089) Breaking out a piece of #107982 as per #107982 (comment) to create new RPC methods instead of renaming them. A follow up PR will update the usage (in tests as well, seemed silly to duplicate the tests for this PR when I can just update the call) and a final one will remove the old one.
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
…nstallation deletion (#108089) Breaking out a piece of #107982 as per #107982 (comment) to create new RPC methods instead of renaming them. A follow up PR will update the usage (in tests as well, seemed silly to duplicate the tests for this PR when I can just update the call) and a final one will remove the old one.
DominikB2014
pushed a commit
that referenced
this pull request
Feb 13, 2026
…nstallation deletion (#108089) Breaking out a piece of #107982 as per #107982 (comment) to create new RPC methods instead of renaming them. A follow up PR will update the usage (in tests as well, seemed silly to duplicate the tests for this PR when I can just update the call) and a final one will remove the old one.
Member
Author
|
Closing in favor of doing this in 3 separate PRs. |
ceorourke
added a commit
that referenced
this pull request
Feb 19, 2026
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #107879 to fully remove the installation uuid and rename the function to closer match what it's doing.
I added logs in the last PR to ensure we are passing
sentry_app_idandorganization_idso it's safe to expect them to be there.I'll let that bake for a day before merging this.It's been ~18 hours and we have no logs indicating we are not passing what we expect.