fix(issues): Move user serialization out of loop in ignored issues handler#116246
Merged
shashjar merged 1 commit intoMay 26, 2026
Conversation
github-actions
Bot
added
the
Scope: Backend
cvxluo
approved these changes
May 26, 2026
shayna-ch
approved these changes
May 26, 2026
shashjar
deleted the
shashjar/remove-redundant-serialization-calls-in-ignored-issues-handler
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
user_service.serialize_many()call andIgnoredStatusDetailsconstruction were mistakenly placed inside thefor group in group_list:loop; neither depends on thegroup. We should only run this serialization and construction once. No change in behavior, just removing the redundant calls.