Skip to content

fix(issues): Move user serialization out of loop in ignored issues handler #116246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shashjar merged 1 commit into from
May 26, 2026
+15 −15
Merged

fix(issues): Move user serialization out of loop in ignored issues handler #116246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/sentry/issues/ignored.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,21 +138,21 @@ def handle_ignored(
Group.objects.filter(id=group.id, status=GroupStatus.UNRESOLVED).update(
substatus=GroupSubStatus.UNTIL_CONDITION_MET, status=GroupStatus.IGNORED
)
serialized_user = None
with in_test_hide_transaction_boundary():
if acting_user:
serialized_user = user_service.serialize_many(
filter=dict(user_ids=[acting_user.id]),
as_user=serialize_generic_user(acting_user),
)
new_status_details = IgnoredStatusDetails(
ignoreCount=ignore_count,
ignoreUntil=ignore_until,
ignoreUserCount=ignore_user_count,
ignoreUserWindow=ignore_user_window,
ignoreWindow=ignore_window,
actor=serialized_user[0] if serialized_user else None,
)
serialized_user = None
with in_test_hide_transaction_boundary():
if acting_user:
serialized_user = user_service.serialize_many(
filter=dict(user_ids=[acting_user.id]),
as_user=serialize_generic_user(acting_user),
)
new_status_details = IgnoredStatusDetails(
ignoreCount=ignore_count,
ignoreUntil=ignore_until,
ignoreUserCount=ignore_user_count,
ignoreUserWindow=ignore_user_window,
ignoreWindow=ignore_window,
actor=serialized_user[0] if serialized_user else None,
)
else:
GroupSnooze.objects.filter(group__in=group_list).delete()

Expand Down
Loading