Skip to content

Add FetchWithHeaders to FetcherInterface#13

Merged
andrew merged 2 commits intomainfrom
add-fetch-with-headers
Mar 29, 2026
Merged

Add FetchWithHeaders to FetcherInterface#13
andrew merged 2 commits intomainfrom
add-fetch-with-headers

Conversation

@andrew
Copy link
Copy Markdown
Contributor

@andrew andrew commented Mar 26, 2026

Adds FetchWithHeaders(ctx, url, http.Header) to FetcherInterface and implements it on both Fetcher and CircuitBreakerFetcher. This allows callers to pass per-request HTTP headers through the fetcher, which is needed for registries that require authentication tokens on artifact downloads.

Related: git-pkgs/proxy#43

Allows callers to pass per-request HTTP headers through the fetcher,
which is needed for registries that require authentication tokens
(e.g. Docker Hub requires Bearer tokens even for public images).
@andrew andrew merged commit 497dfae into main Mar 29, 2026
2 checks passed
andrew added a commit to git-pkgs/proxy that referenced this pull request Apr 1, 2026
Replace pre-release pseudo-version with the released v0.4.0 now that
git-pkgs/registries#13 has been merged.
andrew added a commit to git-pkgs/proxy that referenced this pull request Apr 1, 2026
Replace pre-release pseudo-version with the released v0.4.0 now that
git-pkgs/registries#13 has been merged.
andrew added a commit to git-pkgs/proxy that referenced this pull request Apr 1, 2026
* Fix container blob caching by passing auth token to fetcher

The container handler was calling GetOrFetchArtifactFromURL without
authentication headers, causing Docker Hub to return 401. The fallback
proxyBlobWithAuth path had auth but bypassed the cache entirely.

Now passes the Bearer token through GetOrFetchArtifactFromURLWithHeaders
so blobs are both authenticated and cached.

Fixes #43

* Update registries to v0.4.0

Replace pre-release pseudo-version with the released v0.4.0 now that
git-pkgs/registries#13 has been merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant