Skip to content

fix: remove unused export from normalizeDockerHostPathPrefix#3773

Merged
lpcox merged 1 commit into
mainfrom
fix/unexport-normalizeDockerHostPathPrefix
May 25, 2026
Merged

fix: remove unused export from normalizeDockerHostPathPrefix#3773
lpcox merged 1 commit into
mainfrom
fix/unexport-normalizeDockerHostPathPrefix

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented May 25, 2026

Remove the export keyword from normalizeDockerHostPathPrefix in src/services/host-path-prefix.ts. The function is only used internally within the same file — no other module imports it.

Fixes #3762

The function is only used internally within host-path-prefix.ts.
No other module imports it.

Fixes #3762

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 25, 2026 15:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the public API surface of src/services/host-path-prefix.ts by making normalizeDockerHostPathPrefix a file-local helper, aligning with how the module is consumed elsewhere in the codebase (only applyHostPathPrefixToVolumes is imported by other services).

Changes:

  • Remove the export keyword from normalizeDockerHostPathPrefix, keeping it as an internal helper within host-path-prefix.ts.
Show a summary per file
File Description
src/services/host-path-prefix.ts Makes normalizeDockerHostPathPrefix private to the module while preserving existing internal usage.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 96.53% 96.58% 📈 +0.05%
Statements 96.37% 96.42% 📈 +0.05%
Functions 97.99% 97.99% ➡️ +0.00%
Branches 90.88% 90.92% 📈 +0.04%
📁 Per-file Coverage Changes (2 files)
File Lines (Before → After) Statements (Before → After)
src/services/host-path-prefix.ts 87.5% → 87.0% (-0.55%) 89.3% → 88.9% (-0.40%)
src/config-writer.ts 89.3% → 90.9% (+1.65%) 89.3% → 90.9% (+1.65%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions
Copy link
Copy Markdown
Contributor

✅ Smoke test validation complete

  • ✅ GitHub API: 2 recent PRs loaded
  • ✅ Playwright check: PASS
  • ✅ File verification: Passed

Result: All checks passed

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

GitHub MCP: Retrieved PR #3766 (fix: use module-level mock for fs.existsSync in config-writer test)
GitHub.com: Pre-step HTTP status check needed
File Write/Read: File not found at expected path

Overall Status: ⚠️ PARTIAL (MCP working, file test failed)

@lpcox

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results: PASS ✅

PR #3773: fix: remove unused export from normalizeDockerHostPathPrefix (author: @lpcox)

  • ✅ GitHub MCP (list PRs)
  • ✅ GitHub.com connectivity (HTTP 200)
  • ✅ File write/read (AWF smoke test OK)
  • ✅ BYOK inference (responding via api-proxy → api.githubcopilot.com)

Mode: COPILOT_OFFLINE=true (BYOK offline mode via api-proxy sidecar)
Overall: PASS

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Smoke test Codex: FAIL
PRs: fix: use module-level mock for fs.existsSync in config-writer test; Increase security-guard max-turns from 3 to 10
✅ Reviewed last 2 merged PRs
❌ safeinputs-gh PR query unavailable
✅ Playwright GitHub title check
❌ Tavily search unavailable
✅ File write/read
❌ Discussion query unavailable; skipped discussion comment
✅ npm ci && npm run build

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Services Connectivity

Redis: Connection timeout (no PONG received)
PostgreSQL pg_isready: No response from host.docker.internal:5432
PostgreSQL query: Not tested (pg_isready failed)

Result: ❌ FAIL — Services not reachable from AWF sandbox

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Runtime Version Test Results

Comparison of runtime versions between host and chroot environments:

Runtime Host Version Chroot Version Match?
Python 3.12.13 3.12.3 ❌ NO
Node.js v24.15.0 v22.22.3 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall Result: ❌ Not all runtimes match

Analysis

  • Python: Minor version mismatch (3.12.13 vs 3.12.3) - both are Python 3.12.x
  • Node.js: Major version mismatch (v24 vs v22) - significant difference
  • Go: Versions match exactly

The chroot environment successfully provides access to host runtimes, though version parity depends on the Ubuntu 22.04 base image vs GitHub Actions runner versions.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results: MCP: FAIL, Connectivity: FAIL, File: PASS, Bash: PASS. Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color passed ✅ PASS
Go env passed ✅ PASS
Go uuid passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx passed ✅ PASS
Node.js execa passed ✅ PASS
Node.js p-limit passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

All build and test tasks completed successfully across all ecosystems!

Generated by Build Test Suite for issue #3773 · ● 14M ·

@lpcox lpcox merged commit 8b70654 into main May 25, 2026
63 of 65 checks passed
@lpcox lpcox deleted the fix/unexport-normalizeDockerHostPathPrefix branch May 25, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Unused export: normalizeDockerHostPathPrefix in host-path-prefix module

2 participants