fix: remove unused export from normalizeDockerHostPathPrefix#3773
Conversation
The function is only used internally within host-path-prefix.ts. No other module imports it. Fixes #3762 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces the public API surface of src/services/host-path-prefix.ts by making normalizeDockerHostPathPrefix a file-local helper, aligning with how the module is consumed elsewhere in the codebase (only applyHostPathPrefixToVolumes is imported by other services).
Changes:
- Remove the
exportkeyword fromnormalizeDockerHostPathPrefix, keeping it as an internal helper withinhost-path-prefix.ts.
Show a summary per file
| File | Description |
|---|---|
src/services/host-path-prefix.ts |
Makes normalizeDockerHostPathPrefix private to the module while preserving existing internal usage. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
Coverage comparison generated by |
|
✅ Smoke test validation complete
Result: All checks passed
|
Smoke Test Results✅ GitHub MCP: Retrieved PR #3766 (fix: use module-level mock for fs.existsSync in config-writer test) Overall Status:
|
Smoke Test Results: PASS ✅PR #3773: fix: remove unused export from normalizeDockerHostPathPrefix (author: @lpcox)
Mode: COPILOT_OFFLINE=true (BYOK offline mode via api-proxy sidecar)
|
|
Smoke test Codex: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test: Services Connectivity❌ Redis: Connection timeout (no PONG received) Result: ❌ FAIL — Services not reachable from AWF sandbox
|
Chroot Runtime Version Test ResultsComparison of runtime versions between host and chroot environments:
Overall Result: ❌ Not all runtimes match Analysis
The chroot environment successfully provides access to host runtimes, though version parity depends on the Ubuntu 22.04 base image vs GitHub Actions runner versions.
|
|
Smoke Test Results: MCP: FAIL, Connectivity: FAIL, File: PASS, Bash: PASS. Overall: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS All build and test tasks completed successfully across all ecosystems!
|
Remove the
exportkeyword fromnormalizeDockerHostPathPrefixinsrc/services/host-path-prefix.ts. The function is only used internally within the same file — no other module imports it.Fixes #3762