Improve MJWarp Batch Rendering Documentation#3116
Improve MJWarp Batch Rendering Documentation#3116StafaH wants to merge 2 commits intogoogle-deepmind:mainfrom
Conversation
doc/mjwarp/index.rst
Outdated
| - **Flex**: Currently limited to 2D and 3D :ref:`flex<deformable-flex>` objects. Performance is expected to improve as | ||
| this feature is further developed. | ||
| - **Scaling**: Rendering scales linearly with resolution (total number of pixels) and number of cameras. | ||
| - **Scaling**: Rendering scales linearly with resolution (total pixel count) and camera count (parallel structure). |
There was a problem hiding this comment.
Remove (parallel structure). I was just explaining the style reason.
doc/mjwarp/index.rst
Outdated
| =============== | ||
|
|
||
| MJWarp provides a high-throughput ray-tracing batch renderer built on | ||
| MJWarp provides a high-throughput ray tracing batch renderer built on |
There was a problem hiding this comment.
'ray-tracing' is a compound adjective preceding a noun so we should probably include the hyphen here
There was a problem hiding this comment.
It’s not a compound adjective here, it’s a noun phrase.
There was a problem hiding this comment.
might be wrong here but i think in the context of this sentence renderer is the noun and 'ray tracing'/'ray-tracing' is the modifier?
we could rephrase to something like: '... a high-throughput batch renderer utilizing ray tracing built on ...'
There was a problem hiding this comment.
or something like 'a batch renderer for high-throughput ray tracing'
doc/mjwarp/index.rst
Outdated
| - **Flex**: Currently limited to 2D and 3D :ref:`flex<deformable-flex>` objects. Performance is expected to improve as | ||
| this feature is further developed. | ||
| - **Scaling**: Rendering scales linearly with resolution (total number of pixels) and number of cameras. | ||
| - **Scaling**: Rendering scales linearly with resolution (total pixel count) and camera count (parallel structure). |
There was a problem hiding this comment.
not totally sure what '(parallel structure)' means in terms of scaling here
There was a problem hiding this comment.
That's a stray review comment. I was originally explaining that "scales linearly with resolution (total number of pixels) and number of cameras." did not have parallel structure and "number of cameras" should be replaced with "camera count".
|
Fixed both comments. Thanks @thowell and @kevinzakka |
|
thanks @StafaH and @kevinzakka! |
3 participants
No description provided.