feat: Security page — permissions, secrets vault, audit log#23
Merged
feat: Security page — permissions, secrets vault, audit log#23
Conversation
Add a Security section to the desktop app with three sub-pages: - Permissions: read/write ~/.claude/settings.json with preset profiles (Strict, Standard, Permissive), tool allow/deny/ask columns, path and network host management, and contextual suggestion dropdowns - Secrets: macOS Keychain integration for sensitive env vars via the `security` CLI, plus non-sensitive env config in ~/.harness-kit/env.json - Audit Log: SQLite-backed event log for permission changes, secret operations, and preset applications with category filters and pagination Backend: security.rs (9 commands) + security_db.rs (2 commands) Frontend: 3 pages, tauri bridge, nav + routing integration Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…or handling - Validate secret names against strict alphanumeric pattern before passing to macOS `security` CLI (prevents special char injection) - Actually check keychain for each secret via `find-generic-password` so the is_set status badge reflects reality - Replace panicking unwrap() in apply_permissions_to_settings with proper Result propagation - Record audit entry when clearing old audit log entries - Add category index on audit_log table for filter query performance - Only auto-save env config on blur when values have actually changed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
siracusa5
force-pushed
the
feat/security-page
branch
from
e908eb9 to
a645cf8
Compare
siracusa5
added a commit
that referenced
this pull request
Mar 16, 2026
The security feature merge (#23) lost the mod.rs declarations for security and security_db during conflict resolution — files existed but weren't wired up, breaking desktop compilation. Adds cargo check to the desktop-build-test CI job so Rust compilation errors are caught before merge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
siracusa5
added a commit
that referenced
this pull request
Mar 16, 2026
The security feature merge (#23) lost the mod.rs declarations for security and security_db during conflict resolution — files existed but weren't wired up, breaking desktop compilation. Adds cargo check to the desktop-build-test CI job so Rust compilation errors are caught before merge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Security section to the desktop app with three sub-pages for managing permissions, secrets, and an audit trail. Gives engineers visibility into tool access rules, centralized secret management via macOS Keychain, and a log of all security-related changes.
Changes
~/.claude/settings.jsonpermissions with three hardcoded presets (Strict, Standard, Permissive), editable tool allow/deny/ask columns with contextual suggestion dropdowns, path and network host management, and a confirmation dialog for preset applicationsecurityCLI, non-sensitive env config editor for~/.harness-kit/env.json, status badges for set/missing secretsDbstruct) with category filter pills, expandable JSON details, pagination, and clear-old-entries actionsecurity.rs(9 commands) +security_db.rs(2 commands) — settings.json backup before every write, secret values never loggedfs:allow-write-text-file, expandedfs:scopeto include~/.harness-kit, addedsecurityCLI to shell allow-executePermissionsState,SecurityPreset,KeychainSecretInfo,EnvConfigEntry,AuditEntryTest Plan
cargo check— Rust compiles cleanlytsc --noEmit— no new TypeScript errorspnpm dev:desktop— app launches, Security section appears in sidebarNotes
feat/comparator-phase-2(needs that branch merged first forDbstruct, shell plugin, SQLite infrastructure)securityCLI — cross-platform support is a future follow-up🤖 Generated with Claude Code