Improve OSD Glide Slope implementation#11615

Open

y-decimal wants to merge 26 commits into

iNavFlight:release/9.1from

y-decimal:osd-glide-refactor

Commits on May 30, 2026

Commits on Jun 3, 2026

feat: lay out basic structure for new glide slope calculation
y-decimal
committed
fix: change glideBuffer allocation to static for now
y-decimal
committed
fix: incorrect comparison in sample interval calculation
y-decimal
committed
fix: incorrect use of ternary in sample interval increment logic
y-decimal
committed
refactor: rename glideSlope to glideRatio for clarity in OSD element
y-decimal
committed
fix: change glideSampleRate, glideSampleTimeFrame, and minimumSampleCount to const
y-decimal
committed
fix: add glideLastSampleTime to track the last sample time in osdDrawSingleElement
y-decimal
committed
feat: add calculateGlideRatioFromBuffer function for glide ratio calculation from position samples
y-decimal
committed
feat: implement lazy allocation for glide buffer to allow changing parameters via cli variables
y-decimal
committed
feat: add osd_glide_sample_rate and osd_glide_sample_time_frame settings for glide slope configuration
y-decimal
committed
feat: add isDataValidForGlideRatio function to validate glide ratio conditions
y-decimal
committed
fix: update glideLastSampleTime correctly in osdDrawSingleElement function
y-decimal
committed
fix: update ascent duration check in isDataValidForGlideRatio function to 4 seconds
y-decimal
committed
style: update function signature of isDataValidForGlideRatio to include void parameter
y-decimal
committed
cleanup: remove now unused hardcoded glide sample rate and time frame constants
y-decimal
committed
fix: calculate glide ratio using only the valid samples collected in osdDrawSingleElement function
y-decimal
committed
refactor: adjust minimum sample count calculation to be relative to total sample count
y-decimal
committed
fix: clarify comment regarding glide slope naming consistency
y-decimal
committed
refactor: handle glide slope calculation outside of the glide slope draw call and make glideslope available for other functions to allow glideTime and glideDistance to use it for their calculations
y-decimal
committed
refactor: update glide time calculation to use glide ratio if available
y-decimal
committed
fix: ensure glide sample rate and time frame default to valid values if misconfigured
y-decimal
committed
fix: free glide buffer when required size is zero to prevent memory leaks and return early
y-decimal
committed
fix: reset sampling state when buffer size changes to ensure accurate glide ratio calculations and prevent out of bounds array access
y-decimal
committed
fix: correct buffer offset for glide distance display to ensure proper formatting
y-decimal
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve OSD Glide Slope implementation#11615

Improve OSD Glide Slope implementation#11615
y-decimal wants to merge 26 commits into
iNavFlight:release/9.1from
y-decimal:osd-glide-refactor

Commits on May 30, 2026

dshot ignore fix

Merge pull request #11604 from P-I-Engineer/dshot-beeper-buzzer-ignore-fix

Commits on Jun 3, 2026

feat: lay out basic structure for new glide slope calculation

fix: change glideBuffer allocation to static for now

fix: incorrect comparison in sample interval calculation

fix: incorrect use of ternary in sample interval increment logic

refactor: rename glideSlope to glideRatio for clarity in OSD element

fix: change glideSampleRate, glideSampleTimeFrame, and minimumSampleCount to const

fix: add glideLastSampleTime to track the last sample time in osdDrawSingleElement

feat: add calculateGlideRatioFromBuffer function for glide ratio calculation from position samples

feat: implement lazy allocation for glide buffer to allow changing parameters via cli variables

feat: add osd_glide_sample_rate and osd_glide_sample_time_frame settings for glide slope configuration

feat: add isDataValidForGlideRatio function to validate glide ratio conditions

fix: update glideLastSampleTime correctly in osdDrawSingleElement function

fix: update ascent duration check in isDataValidForGlideRatio function to 4 seconds

style: update function signature of isDataValidForGlideRatio to include void parameter

cleanup: remove now unused hardcoded glide sample rate and time frame constants

fix: calculate glide ratio using only the valid samples collected in osdDrawSingleElement function

refactor: adjust minimum sample count calculation to be relative to total sample count

fix: clarify comment regarding glide slope naming consistency

refactor: handle glide slope calculation outside of the glide slope draw call and make glideslope available for other functions to allow glideTime and glideDistance to use it for their calculations

refactor: update glide time calculation to use glide ratio if available

fix: ensure glide sample rate and time frame default to valid values if misconfigured

fix: free glide buffer when required size is zero to prevent memory leaks and return early

fix: reset sampling state when buffer size changes to ensure accurate glide ratio calculations and prevent out of bounds array access

fix: correct buffer offset for glide distance display to ensure proper formatting