Add eql? and hash methods for IPv? and Prefix? classes (fix for #21)#22
Open
patdowney wants to merge 2 commits intoipaddress-gem:masterfrom
Open
Add eql? and hash methods for IPv? and Prefix? classes (fix for #21)#22patdowney wants to merge 2 commits intoipaddress-gem:masterfrom
patdowney wants to merge 2 commits intoipaddress-gem:masterfrom
Conversation
…ix behave as expected when used in sets or hashes.
Author
|
Sorry, I had hoped this would attach to the issue I created previously. |
…IPAddress::Prefix instance.
smortex
requested changes
Aug 30, 2017
Contributor
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Hello, this is an old PR!
Can you please rebase it on top of master, fix conflicts and add the tests you wrote in #21?
Now, GitHub can allows maintainers to add commits into contributors branches, this would allow us to take care of this ourselves. If you are interested, please enable this feature (on the PR page, at the bottom of the right column, under the participants list, check Allow edits from maintainers.).
TheHolyRoger
pushed a commit
to whatagem/ipaddress
that referenced
this pull request
Oct 18, 2021
Update folders to ipaddress_2 for gem to load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit adds eql? and hash methods that will allows the IPv? and Prefix? classes to behave as expected when used in hashes or sets.