Skip to content

Comments

Don't try to parse if no targets#677

Merged
attiasas merged 3 commits intojfrog:devfrom
attiasas:fix_no_target_bug
Feb 23, 2026
Merged

Don't try to parse if no targets#677
attiasas merged 3 commits intojfrog:devfrom
attiasas:fix_no_target_bug

Conversation

@attiasas
Copy link
Collaborator

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

In jf scan, it is possible to pass arguments with no actual artifacts to scan.
That caused the following issue:

[Error] failed to record results: ParseNewTargetResults must be called before starting to parse issues

@attiasas attiasas requested a review from a team February 18, 2026 13:38
@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Feb 18, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 23, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 23, 2026
@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a tests case if some test for this exists

@attiasas attiasas merged commit 793d70e into jfrog:dev Feb 23, 2026
62 checks passed
@attiasas attiasas deleted the fix_no_target_bug branch February 23, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants