Skip to content

Don't try to parse if no targets #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
attiasas merged 3 commits into from
Feb 23, 2026
Merged

Don't try to parse if no targets #677

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
371b1ea
Don't try to parse if no targets
attiasas Feb 18, 2026
4843ff0
fix static tests
attiasas Feb 19, 2026
576bfca
Merge remote-tracking branch 'upstream/dev' into fix_no_target_bug
attiasas Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions utils/results/conversion/convertor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func parseCommandResults[T interface{}](params ResultConvertParams, parser Resul
}
}
if params.HasViolationContext || cmdResults.HasViolationContext() {
if err = parseViolations(parser, cmdResults.Violations); err != nil {
if err = parseViolations(parser, cmdResults.Violations, cmdResults.Targets); err != nil {
return
}
}
Expand Down Expand Up @@ -222,8 +222,9 @@ func parseJasResults[T interface{}](params ResultConvertParams, parser ResultsSt
return parser.ParseMalicious(targetResults.JasResults.JasVulnerabilities.MaliciousScanResults)
}

func parseViolations[T interface{}](parser ResultsStreamFormatParser[T], violations *violationutils.Violations) (err error) {
if violations == nil {
func parseViolations[T interface{}](parser ResultsStreamFormatParser[T], violations *violationutils.Violations, targets []*results.TargetResults) (err error) {
if violations == nil || len(targets) == 0 {
// When there are no targets, there are no violations to parse
return
}
// Parsing JAS Violations results
Expand Down
Loading