chore: split e2e tests for real-time output#152
Merged
tnsardesai merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
`go test ./...` buffers each package's output until the package completes. Since e2e tests take ~2 minutes (testcontainers), nothing is visible until they all finish. Running e2e as a separate `go test` invocation makes it the only active package, so output streams in real time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tnsardesai
force-pushed
the
chore/split-e2e-test-output
branch
from
20e9496 to
310bc74
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| go vet ./... | ||
| # E2E tests use dynamic ports via TestContainer, enabling parallel execution | ||
| go test -v -race ./... | ||
| go test -v -race $$(go list ./... | grep -v /e2e$$) |
There was a problem hiding this comment.
Filtered package list can fail test target
Low Severity
go test -v -race $$(go list ./... | grep -v /e2e$$) depends on grep -v returning matches. If every listed package is filtered out, grep exits non-zero and make test stops before running ./e2e/, even though tests may be valid. This introduces a brittle failure mode in server/Makefile.
ulziibay-kernel
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testso e2e tests run as a separatego testinvocation instead of bundled ingo test ./...Why
go test ./...buffers each package's output until the package completes. Since e2e tests take ~2 minutes (testcontainers), the terminal shows nothing for that entire duration — it looks like the tests are hung.Running e2e as a separate
go test ./e2e/invocation makes it the only active package, so output (container startup, health checks, test progress) streams in real time.There's no way to disable per-package buffering in
go testwhen running multiple packages in parallel — it's intentional to prevent interleaved output. The-p 1flag would work but slows down the overall run which is why it was removed #137. The split approach gives real-time streaming where it matters (e2e) with no performance cost.Test plan
make testpasses (all unit + e2e tests green)🤖 Generated with Claude Code
Note
Low Risk
Makefile-only change that alters test execution ordering/invocation but not production code; main risk is accidentally excluding/duplicating packages due to the
go list | grep -v /e2e$filter.Overview
make testnow runs non-e2e packages first and executes./e2etests as a separatego teststep, with a banner printed before the e2e run to make progress/logs visible while testcontainers start up.Written by Cursor Bugbot for commit 310bc74. This will update automatically on new commits. Configure here.