Skip to content

chore: split e2e tests for real-time output #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnsardesai merged 1 commit into from
Feb 12, 2026
Merged

chore: split e2e tests for real-time output #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,14 @@ build: | $(BIN_DIR)
dev: build $(RECORDING_DIR)
OUTPUT_DIR=$(RECORDING_DIR) DISPLAY_NUM=$(DISPLAY_NUM) ./bin/api

# we run the e2e tests separately so that we can see the logs from the e2e tests as they run instead of waiting for all tests to complete
test:
go vet ./...
# E2E tests use dynamic ports via TestContainer, enabling parallel execution
go test -v -race ./...
go test -v -race $$(go list ./... | grep -v /e2e$$)
Copy link

@cursor cursor bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtered package list can fail test target

Low Severity

go test -v -race $$(go list ./... | grep -v /e2e$$) depends on grep -v returning matches. If every listed package is filtered out, grep exits non-zero and make test stops before running ./e2e/, even though tests may be valid. This introduces a brittle failure mode in server/Makefile.

Fix in Cursor Fix in Web

@echo ""
@echo "=== Running e2e tests (testcontainers — this may take a few minutes) ==="
@echo ""
go test -v -race ./e2e/

clean:
@rm -rf $(BIN_DIR)
Expand Down
Loading