fix(webrtc-sys): replace __sF with POSIX fdopen for NDK 28+#993
Open
fraschm1998 wants to merge 1 commit intolivekit:mainfrom
Open
fix(webrtc-sys): replace __sF with POSIX fdopen for NDK 28+#993fraschm1998 wants to merge 1 commit intolivekit:mainfrom
fraschm1998 wants to merge 1 commit intolivekit:mainfrom
Conversation
The __sF libc internal symbol was removed in Android NDK 28. The
previous workaround in android.cpp referenced &__sF[1] and &__sF[2]
to force-define stdout/stderr, causing compilation errors with
NDK 28 and 29:
src/android.cpp:34:17: error: use of undeclared identifier '__sF'
34 | FILE *stdout = &__sF[1];
Use POSIX fdopen(STDOUT_FILENO/STDERR_FILENO) instead — works across
all NDK versions and avoids reaching into libc internals.
|
Massimo Fraschetti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
webrtc-sys/src/android.cppreferences__sF, a libc internal symbol that was removed in Android NDK 28. This causes compilation errors when building with NDK 28 or 29:Fix
Replace the
__sFreferences with POSIXfdopen(STDOUT_FILENO, ...)andfdopen(STDERR_FILENO, ...). This:stdout/stderrsymbols when WebRTC examples need themTested
Builds successfully with NDK 28.0.12916984 and NDK 29.0.14206865 targeting
aarch64-linux-android.Closes #992