Skip to content

fix(webrtc-sys): replace __sF with POSIX fdopen for NDK 28+ #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fraschm1998 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

fix(webrtc-sys): replace __sF with POSIX fdopen for NDK 28+ #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions webrtc-sys/src/android.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include <jni.h>
#include <stdio.h>
#include <unistd.h>
#include <memory>

#include "api/video_codecs/video_decoder_factory.h"
Expand All @@ -27,14 +28,16 @@
#include "sdk/android/native_api/jni/scoped_java_ref.h"
#include "sdk/android/src/jni/jni_helpers.h"

// When we compiling the examples app on Android results in errors
// indicating that the `stderr` and `stdout` symbols cannot be found;
// so we need to force hardcoding them to point to the system symbols.
// When compiling the examples app on Android, the linker complains that
// `stdout` and `stderr` symbols cannot be found. The previous workaround
// referenced `__sF`, but that symbol was removed in NDK 28+.
// Use POSIX `fdopen()` with the standard file descriptors instead — works
// across all NDK versions.
#undef stdout
FILE *stdout = &__sF[1];
FILE *stdout = fdopen(STDOUT_FILENO, "w");

#undef stderr
FILE *stderr = &__sF[2];
FILE *stderr = fdopen(STDERR_FILENO, "w");

namespace livekit_ffi {

Expand Down
Loading