Bump sdk dependencies by korshaknn · Pull Request #6833 · mapbox/mapbox-navigation-android

korshaknn · 2023-01-13T13:32:55Z

Description

Screenshots or Gifs

github-actions · 2023-01-13T13:33:26Z

Changelog

Features

Added RoadComponent.language value. #6833
⚠️ Changed EHorizonEdgeMetadata.names class from RoadName to RoadComponent. #6833
To migrate change your code from:

val shielded = roadName.shielded

into:

val shielded = roadComponent.shield != null

Added support for continuous EV alternatives in NavigationRouteAlternativesObserver. #6833
Fixed issues with map-matching to HOV-only roads. #6833
Set a limit of simultaneously running onboard route requests to avoid too many tasks blocking too much of the device's computing resources. #6833
Fixed an issue with Road Access Policy ignoring the setting to map-match to closed road sections, when enabled. #6833
Added MapboxTripStarter to simplify the solution for managing the trip session and replaying routes. This also makes it possible to share the replay state between drop-in-ui and android-auto. #6794

Bug fixes and improvements

Increased max distance from the user indicator to route line valid to continue vanishing updates from 3m to 10m. #6854
Fixed an issue where alternative routes might have had an incorrect or incomplete portion of the route refreshed or occasionally fail to refresh. #6848
Removed NavigationRoute#hasUnexpectedClosures and added RouteProgress#hasUnexpectedUpcomingClosures instead that checks whether route has upcoming unexpected closures (the algorithm does not take into account closures that the puck has already been on) #6841
Improved NavigationView camera behavior to go back into overview state if routes change during route preview state. #6840
Improved NavigationView camera behavior to ignore keyboard insets. #6845

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Added support for Junction Views. #6849

Bug fixes and improvements

Optimized SpeedLimitWidget memory usage. #6859

gradle/dependencies.gradle

Zayankovsky · 2023-01-13T15:23:10Z

libnavigation-base/api/current.txt

-  public final class RoadName {
-    method public String getName();
-    method public boolean getShielded();
-    property public final String name;
-    property public final boolean shielded;
-  }
-


Are we fine with these breaking changes?

it's EHorizon only, and it's in beta, so I think we are ok
cc @LukasPaczos @Guardiola31337

It's not experimental. I don't think it's OK.

@dzinad we don't have @Experimental annotations for EHorizon classes, but all of them have the next comment

* **NOTE**: The Mapbox Electronic Horizon feature of the Mapbox Navigation SDK is in public beta * and is subject to changes, including its pricing.

Alright then. We should have added the annotation.

let's fix it separately https://mapbox.atlassian.net/browse/NAVSDK-835

codecov · 2023-01-13T16:43:05Z

Codecov Report

Merging #6833 (fe180e3) into main (2e5165e) will increase coverage by 0.01%.
The diff coverage is 11.11%.

@@             Coverage Diff              @@
##               main    #6833      +/-   ##
============================================
+ Coverage     72.66%   72.68%   +0.01%     
  Complexity     5572     5572              
============================================
  Files           783      782       -1     
  Lines         30171    30166       -5     
  Branches       3564     3562       -2     
============================================
+ Hits          21924    21926       +2     
+ Misses         6821     6814       -7     
  Partials       1426     1426

Impacted Files	Coverage Δ
...igation/base/trip/model/eh/EHorizonEdgeMetadata.kt	`0.00% <0.00%> (ø)`
...ox/navigation/base/trip/model/eh/EHorizonMapper.kt	`1.29% <0.00%> (-0.02%)`	⬇️
...mapbox/navigation/base/road/model/RoadComponent.kt	`20.83% <12.50%> (-2.70%)`	⬇️
...ox/navigation/base/internal/factory/RoadFactory.kt	`72.72% <100.00%> (+2.72%)`	⬆️

korshaknn · 2023-01-13T18:41:07Z

@dzinad I've changed tolerance in WaypointsTest to pass them. Could you double check?

dzinad · 2023-01-16T11:30:16Z

@dzinad I've changed tolerance in WaypointsTest to pass them. Could you double check?

Looks fine.

changelog/unreleased/features/6833.md

libnavigation-base/src/main/java/com/mapbox/navigation/base/road/model/RoadComponent.kt

libnavigation-base/src/main/java/com/mapbox/navigation/base/trip/model/eh/RoadName.kt

korshaknn · 2023-01-18T10:33:11Z

instrumentation test additional_alternative_is_not_force_to_invoke_alternatives_observer
always crashes on API 33 and 31 with a native crash. https://console.firebase.google.com/u/0/project/mapbox-navigation-android/testlab/histories/bh.54eb2dd57e959221/matrices/6292238984157145847/executions/bs.e41875b0127bbda1
at the same time it passes on API 23
locally it passes on API 33
cc @LukasPaczos @averkhaturau

LukasPaczos · 2023-01-24T11:01:13Z

changelog/unreleased/features/6833.md

+into:
+```kotlin
+val shielded = roadComponent.shield != null
+```


Suggested change

```

- Added support for continuous EV alternatives in `NavigationRouteAlternativesObserver`.

- Fixed issues with map-matching to HOV-only roads.

- Set a limit of simultaneously running onboard route requests to avoid too many tasks blocking too much of the device's computing resources.

- Fixed an issue with Road Access Policy ignoring the setting to map-match to closed road sections, when enabled.

cc @averkhaturau @mskurydin to double-check

LukasPaczos · 2023-01-24T12:11:32Z

changelog/unreleased/features/6833.md

+- Added `RoadComponent.language` value.
+- :warning: Changed `EHorizonEdgeMetadata.names` class from `RoadName` to `RoadComponent`.


Suggested change

- Added `RoadComponent.language` value.

- :warning: Changed `EHorizonEdgeMetadata.names` class from `RoadName` to `RoadComponent`.

- :warning: Changed `EHorizonEdgeMetadata.names` class from `RoadName` to `RoadComponent`.

- Added `RoadComponent.language` value.

nit, this way it will be easier to read.

I see we're done with CI, in this case we can skip this. We can always address when composing final changelog.

korshaknn requested review from Guardiola31337, LukasPaczos and Zayankovsky January 13, 2023 13:32

korshaknn self-assigned this Jan 13, 2023

korshaknn force-pushed the knn_bump_sdk_deps branch from b8ed26a to 8970c1e Compare January 13, 2023 13:33

LukasPaczos reviewed Jan 13, 2023

View reviewed changes

gradle/dependencies.gradle Show resolved Hide resolved

korshaknn force-pushed the knn_bump_sdk_deps branch 4 times, most recently from 2b7b890 to 8f6746f Compare January 13, 2023 15:21

Zayankovsky reviewed Jan 13, 2023

View reviewed changes

korshaknn force-pushed the knn_bump_sdk_deps branch from 8f6746f to 766e8a7 Compare January 13, 2023 15:58

korshaknn force-pushed the knn_bump_sdk_deps branch from 766e8a7 to 2548975 Compare January 13, 2023 18:40

LukasPaczos reviewed Jan 16, 2023

View reviewed changes

S2Ler mentioned this pull request Jan 16, 2023

NavNative v124.0.1 mapbox/mapbox-navigation-ios#4333

Merged

1 task

korshaknn force-pushed the knn_bump_sdk_deps branch 3 times, most recently from a8463ca to f22083f Compare January 18, 2023 09:17

korshaknn force-pushed the knn_bump_sdk_deps branch 2 times, most recently from d3359fd to 48b7854 Compare January 24, 2023 10:42

LukasPaczos reviewed Jan 24, 2023

View reviewed changes

bump sdk dependencies

fe180e3

korshaknn force-pushed the knn_bump_sdk_deps branch from 48b7854 to fe180e3 Compare January 24, 2023 11:26

LukasPaczos approved these changes Jan 24, 2023

View reviewed changes

korshaknn merged commit 09b5248 into main Jan 24, 2023

korshaknn deleted the knn_bump_sdk_deps branch January 24, 2023 12:59

-```
+- Added support for continuous EV alternatives in `NavigationRouteAlternativesObserver`.
+- Fixed issues with map-matching to HOV-only roads.
+- Set a limit of simultaneously running onboard route requests to avoid too many tasks blocking too much of the device's computing resources.
+- Fixed an issue with Road Access Policy ignoring the setting to map-match to closed road sections, when enabled.

		- Added `RoadComponent.language` value.
		- :warning: Changed `EHorizonEdgeMetadata.names` class from `RoadName` to `RoadComponent`.

Conversation

korshaknn commented Jan 13, 2023

Description

Screenshots or Gifs

Uh oh!

github-actions bot commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Features

Bug fixes and improvements

Known issues ⚠️

Other changes

Features

Bug fixes and improvements

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

korshaknn commented Jan 13, 2023

Uh oh!

dzinad commented Jan 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

korshaknn commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Jan 13, 2023 •

edited

Loading

codecov bot commented Jan 13, 2023 •

edited

Loading

korshaknn commented Jan 18, 2023 •

edited

Loading