Fix PHPDoc type of GetPromptRequest::$arguments#285
Open
vjik wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix PHPDoc type of GetPromptRequest::$arguments#285vjik wants to merge 1 commit intomodelcontextprotocol:mainfrom
GetPromptRequest::$arguments#285vjik wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHPDoc type of
GetPromptRequest::$argumentsfromarray<string, mixed>toarray<string, string>Motivation and Context
The MCP specification defines prompt arguments as a map of string keys to string values. The PHPDoc annotation for
GetPromptRequest::$argumentsincorrectly usedarray<string, mixed>, which was overly permissive and inconsistent with the spec. This fix aligns the type hint with the actual contract.How Has This Been Tested?
The change is documentation-only (PHPDoc annotation) and does not affect runtime behavior. Existing tests continue to pass.
Breaking Changes
None. This is a PHPDoc-only change with no impact on runtime behavior or public API signatures.
Types of changes
Checklist
Additional context
Affected annotations:
@param array<string, string>|null $argumentsin the constructor@return array{name: string, arguments?: array<string, string>}ingetParams()