Skip to content

Fix PHPDoc type of GetPromptRequest::$arguments #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vjik wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fix PHPDoc type of GetPromptRequest::$arguments #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ All notable changes to `mcp/sdk` will be documented in this file.
* Add `LenientOidcDiscoveryMetadataPolicy` for identity providers that omit `code_challenge_methods_supported` (e.g. FusionAuth, Microsoft Entra ID)
* Add OAuth 2.0 Dynamic Client Registration middleware (RFC 7591)
* Add optional `title` field to `Prompt` and `McpPrompt` for MCP spec compliance
* Fix PHPDoc type of `GetPromptRequest::$arguments` from `array<string, mixed>` to `array<string, string>` per MCP spec
* [BC Break] `Builder::addPrompt()` signature changed — `$title` parameter added between `$name` and `$description`. Callers using positional arguments for `$description` must switch to named arguments.

0.4.0
Expand Down
4 changes: 2 additions & 2 deletions src/Schema/Request/GetPromptRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ final class GetPromptRequest extends Request
{
/**
* @param string $name the name of the prompt to get
* @param array<string, mixed>|null $arguments the arguments to pass to the prompt
* @param array<string, string>|null $arguments the arguments to pass to the prompt
*/
public function __construct(
public readonly string $name,
Expand Down Expand Up @@ -56,7 +56,7 @@ protected static function fromParams(?array $params): static
}

/**
* @return array{name: string, arguments?: array<string, mixed>}
* @return array{name: string, arguments?: array<string, string>}
*/
protected function getParams(): array
{
Expand Down
Loading