Use rescue StandardError for stream close#286
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Use rescue StandardError for stream close#286koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
rescue StandardError for stream close#286koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
koic
force-pushed
the
use_rescue_standard_error_for_stream_close
branch
from
9c68789 to
7954cfd
Compare
## Motivation and Context Replace bare `rescue` with explicit `rescue StandardError` in stream cleanup to clarify intent, with a comment explaining why. In Ruby, `rescue` without an exception class is equivalent to `rescue StandardError`, so this is a readability improvement with no behavior change. ## How Has This Been Tested? Existing tests pass. ## Breaking Changes None.
koic
force-pushed
the
use_rescue_standard_error_for_stream_close
branch
from
7954cfd to
d3f400f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Replace bare
rescuewith explicitrescue StandardErrorin stream cleanup to clarify intent, with a comment explaining why. In Ruby,rescuewithout an exception class is equivalent torescue StandardError, so this is a readability improvement with no behavior change.How Has This Been Tested?
Existing tests will pass.
Breaking Changes
This is a readability improvement with no behavior change.
Types of changes
Checklist