Skip to content

Use rescue StandardError for stream close #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koic wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Use rescue StandardError for stream close #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/mcp/server/transports/streamable_http_transport.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ def reap_expired_sessions
# removed from `@sessions` above, so other threads will not find them
# and will not attempt to close the same stream.
stream.close
rescue
nil
rescue StandardError
# Ignore close-related errors from already closed/broken streams.
end
end

Expand Down Expand Up @@ -239,8 +239,8 @@ def cleanup_session_unsafe(session_id)

begin
session[:stream]&.close
rescue
nil
rescue StandardError
# Ignore close-related errors from already closed/broken streams.
end
@sessions.delete(session_id)
end
Expand Down