fix(NODE-6642): include install script in published files#110
Merged
tadjik1 merged 1 commit intoMay 22, 2026
Merged
Conversation
|
@axelonet , thanks for the PR! The team will look into this fix. |
There was a problem hiding this comment.
Pull request overview
Fixes a packaging issue in @mongodb-js/zstd where npm install ... --build-from-source could fail because the install script referenced a file that wasn’t included in the published tarball.
Changes:
- Adds
etc/install-zstd.shto thefilesallowlist so it is shipped in the npm package.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
5 tasks
5 tasks
Contributor
|
macos jobs stuck due to macos-13 (intel based runners) are deprecated and removed by Github (follow-up https://jira.mongodb.org/browse/NODE-7593) |
tadjik1
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Fix `npm install @mongodb-js/zstd --build-from-source` failing because the install script referenced a file that was not shipped in the tarball
Notes for Reviewers
the install fallback path runs:
Release Highlight
Package can be build from source upon installation
Fixed an issue where installing
@mongodb-js/zstdwould fail on platforms without a pre-built binary (e.g. new Node.js versions or uncommon architectures). The source-build fallback scriptetc/install-zstd.shwas not included in the published npm package, causing the installation to exit withbash: etc/install-zstd.sh: No such file or directory. The script is now shipped with the package so that source builds work correctly.Thanks @axelonet for submitting the fix!
Double check the following