Skip to content

fix(NODE-6642): include install script in published files#110

Merged
tadjik1 merged 1 commit into
mongodb-js:mainfrom
axelonet:NODE-6642-build-from-source-package-files
May 22, 2026
Merged

fix(NODE-6642): include install script in published files#110
tadjik1 merged 1 commit into
mongodb-js:mainfrom
axelonet:NODE-6642-build-from-source-package-files

Conversation

@axelonet
Copy link
Copy Markdown
Contributor

@axelonet axelonet commented Mar 13, 2026

Description

Summary of Changes

Fix `npm install @mongodb-js/zstd --build-from-source` failing because the install script referenced a file that was not shipped in the tarball

Notes for Reviewers

the install fallback path runs:

  • `npm run clean-install`
  • `npm run install-zstd`
  • `bash etc/install-zstd.sh`

Release Highlight

Package can be build from source upon installation

Fixed an issue where installing @mongodb-js/zstd would fail on platforms without a pre-built binary (e.g. new Node.js versions or uncommon architectures). The source-build fallback script etc/install-zstd.sh was not included in the published npm package, causing the installation to exit with bash: etc/install-zstd.sh: No such file or directory. The script is now shipped with the package so that source builds work correctly.
Thanks @axelonet for submitting the fix!

Double check the following

  • Lint is passing (`npm run check:lint`)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: `type(NODE-xxxx)[!]: description`
    • Example: `feat(NODE-1234)!: rewriting everything in coffeescript`
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@axelonet axelonet requested a review from a team as a code owner March 13, 2026 11:59
@PavelSafronov PavelSafronov added External Submission PR submitted from outside the team tracked-in-jira Ticket filed in MongoDB's Jira system labels Mar 16, 2026
@PavelSafronov
Copy link
Copy Markdown

@axelonet , thanks for the PR! The team will look into this fix.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a packaging issue in @mongodb-js/zstd where npm install ... --build-from-source could fail because the install script referenced a file that wasn’t included in the published tarball.

Changes:

  • Adds etc/install-zstd.sh to the files allowlist so it is shipped in the npm package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread package.json
@tadjik1 tadjik1 self-assigned this May 21, 2026
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 21, 2026
@tadjik1 tadjik1 closed this May 21, 2026
@tadjik1 tadjik1 reopened this May 21, 2026
@tadjik1
Copy link
Copy Markdown
Contributor

tadjik1 commented May 22, 2026

macos jobs stuck due to macos-13 (intel based runners) are deprecated and removed by Github (follow-up https://jira.mongodb.org/browse/NODE-7593)

@tadjik1 tadjik1 merged commit ac07be6 into mongodb-js:main May 22, 2026
53 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

External Submission PR submitted from outside the team Primary Review In Review with primary reviewer, not yet ready for team's eyes tracked-in-jira Ticket filed in MongoDB's Jira system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants