Skip to content

livingobjects#63

Merged
jburel merged 8 commits intoome:masterfrom
pwalczysko:s3
Apr 8, 2026
Merged

livingobjects#63
jburel merged 8 commits intoome:masterfrom
pwalczysko:s3

Conversation

@pwalczysko
Copy link
Copy Markdown
Member

"source": [
"def load_binary_from_s3(id, resolution='4'):\n",
" endpoint_url = 'https://uk1s3.embassy.ebi.ac.uk/'\n",
" endpoint_url = 'https://livingobjects.ebi.ac.uk/'\n",
Copy link
Copy Markdown
Member

@will-moore will-moore Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As on a previous PR, this attempts to load 4007801.zarr from https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.1/4007801.zarr

But this image hasn't been migrated to livingobjects.

Instead you need to use:
https://livingobjects.ebi.ac.uk/idr/zarr/v0.4/idr0044A/4007801.zarr

So, either add the extra idr0044A to the line below,

root = 'idr/zarr/v0.4/idr0044/%s.zarr/%s/' % (id, resolution)\n",

or just update v0.4 here and add idr0044 where the function is called

load_binary_from_s3("idr0044/4007801", resolution)

Copy link
Copy Markdown
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx 👍

# Load-binary
def load_binary_from_s3(id, resolution='4'):
endpoint_url = 'https://uk1s3.embassy.ebi.ac.uk/'
endpoint_url = 'https://livingobjects.ebi.ac.uk/'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As elsewhere, need to use /v0.4/idr0044/%s.zarr/%s/ below and in idr0044_zarr_segmentation_parallel.py and idr0044_zarr_segmentation_parallel.ipynb‎

@pwalczysko
Copy link
Copy Markdown
Member Author

pwalczysko commented Apr 7, 2026

Thanks, as @will-moore is appoving the docs build and mainly the changes in the S3 urls, I have also proven that the latest commits are fixing the micromamba build of the packages under binder/environment.yml.

See https://github.com/pwalczysko/omero-guide-python/actions/runs/24091078016/job/70277302556
I have updated the zarr packages, omero-py and python to 3.12.

The build is unfortunately disabled on this repo due to inactivity. Maybe @jburel or @joshmoore can help please, as I do not have perms to re-enable it https://github.com/ome/omero-guide-python/actions/workflows/build.yml

@jburel jburel closed this Apr 8, 2026
@jburel jburel reopened this Apr 8, 2026
@pwalczysko
Copy link
Copy Markdown
Member Author

This is green now, should we merge @jburel ? Thanks

@jburel jburel merged commit 17536a9 into ome:master Apr 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants