-
Notifications
You must be signed in to change notification settings - Fork 10
livingobjects #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
livingobjects #63
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ed3ea9a
livingobjects
pwalczysko 11182f1
Fix v0.4 and add idr0044 to url
pwalczysko 490b906
Fix the url to the idr0044 image also in 2 .py scripts
pwalczysko 99acd79
fix build
pwalczysko 0332cb6
try
pwalczysko 0f841aa
Change the micromamba setup action
pwalczysko 28ca806
update env packages
pwalczysko a5e6812
Update also distributed
pwalczysko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,8 +46,8 @@ | |
|
|
||
| # Load-binary | ||
| def load_binary_from_s3(id, resolution='4'): | ||
| endpoint_url = 'https://uk1s3.embassy.ebi.ac.uk/' | ||
| root = 'idr/zarr/v0.1/%s.zarr/%s/' % (id, resolution) | ||
| endpoint_url = 'https://livingobjects.ebi.ac.uk/' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As elsewhere, need to use |
||
| root = 'idr/zarr/v0.4/iddr0044/%s.zarr/%s/' % (id, resolution) | ||
| return da.from_zarr(endpoint_url + root) | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As on a previous PR, this attempts to load
4007801.zarrfrom https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.1/4007801.zarrBut this image hasn't been migrated to livingobjects.
Instead you need to use:
https://livingobjects.ebi.ac.uk/idr/zarr/v0.4/idr0044A/4007801.zarr
So, either add the extra
idr0044Ato the line below,or just update v0.4 here and add
idr0044where the function is called