Skip to content

[6/n] add input-output and ref-vs-inline-type-change test cases#17

Merged
sunshowers merged 3 commits into
mainfrom
sunshowers/spr/5n-add-input-output-and-ref-vs-inline-type-change-test-cases
May 12, 2026
Merged

[6/n] add input-output and ref-vs-inline-type-change test cases#17
sunshowers merged 3 commits into
mainfrom
sunshowers/spr/5n-add-input-output-and-ref-vs-inline-type-change-test-cases

Conversation

@sunshowers
Copy link
Copy Markdown
Contributor

@sunshowers sunshowers commented Feb 6, 2026

Introduce these cases now to see how the next commit changes them.

Because of #13 this thankfully results in very little churn.

Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
new_subpath: "",
message: "schema types changed",
class: Incompatible,
details: UnknownDifference,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that this is unknown? or is this expected.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it comes from

drift/src/schema.rs

Lines 516 to 525 in df255a4

_ => self.schema_push_change(
dry_run,
"schema types changed",
&old_schema_type,
&new_schema_type,
comparison,
ChangeClass::Incompatible,
ChangeDetails::UnknownDifference,
),
}
which is from your initial commit :) definitely space to improve this in the future.

@sunshowers sunshowers changed the title [5/n] add input-output and ref-vs-inline-type-change test cases [6/n] add input-output and ref-vs-inline-type-change test cases May 12, 2026
@sunshowers sunshowers changed the base branch from sunshowers/spr/main.5n-add-input-output-and-ref-vs-inline-type-change-test-cases to main May 12, 2026 17:17
Created using spr 1.3.6-beta.1
@sunshowers sunshowers merged commit 9aa8045 into main May 12, 2026
8 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/5n-add-input-output-and-ref-vs-inline-type-change-test-cases branch May 12, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants