Skip to content

[6/n] add input-output and ref-vs-inline-type-change test cases #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunshowers merged 3 commits into from
May 12, 2026
Merged

[6/n] add input-output and ref-vs-inline-type-change test cases #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
896ecda
[spr] changes to main this commit is based on
sunshowers Feb 6, 2026
2d62ea1
[spr] initial version
sunshowers Feb 6, 2026
18d4791
rebase on main
sunshowers May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions tests/cases/simple/base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,34 @@
}
}
}
},
"/echo": {
"post": {
"operationId": "echo",
"summary": "Echo a shared type",
"requestBody": {
"required": true,
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/SharedType"
}
}
}
},
"responses": {
"200": {
"description": "Success",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/SharedType"
}
}
}
}
}
}
}
},
"components": {
Expand Down Expand Up @@ -539,6 +567,14 @@
]
}
]
},
"SharedType": {
"type": "object",
"properties": {
"value": {
"type": "string"
}
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/cases/simple/output/add-operation.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
--- add-operation.json
+++ patched
@@
"summary": "Get arrays"
"summary": "Echo a shared type"
}
},
+ "/foo": {
Expand Down
64 changes: 64 additions & 0 deletions tests/cases/simple/output/input-output-schema-change.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
--- input-output-schema-change.json
+++ patched
@@
"SharedType": {
"properties": {
"value": {
- "type": "string"
+ "type": "integer"
}
},
"type": "object"


Result for patch:
[
Change {
paths: [
ChangePath {
old: [
"#/components/schemas/SharedType/properties/value",
"#/paths/~1echo/post/request_body/content/application~1json/schema/$ref",
],
new: [
"#/components/schemas/SharedType/properties/value",
"#/paths/~1echo/post/request_body/content/application~1json/schema/$ref",
],
comparison: Input,
},
],
changes: [
ChangeInfo {
old_subpath: "",
new_subpath: "",
message: "schema types changed",
class: Incompatible,
details: UnknownDifference,
Copy link
Copy Markdown
Collaborator

@ahl ahl May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that this is unknown? or is this expected.

Copy link
Copy Markdown
Contributor Author

@sunshowers sunshowers May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it comes from

drift/src/schema.rs

Lines 516 to 525 in df255a4

_ => self.schema_push_change(
dry_run,
"schema types changed",
&old_schema_type,
&new_schema_type,
comparison,
ChangeClass::Incompatible,
ChangeDetails::UnknownDifference,
),
}
which is from your initial commit :) definitely space to improve this in the future.

},
],
},
Change {
paths: [
ChangePath {
old: [
"#/components/schemas/SharedType/properties/value",
"#/paths/~1echo/post/responses/200/content/application~1json/schema/$ref",
],
new: [
"#/components/schemas/SharedType/properties/value",
"#/paths/~1echo/post/responses/200/content/application~1json/schema/$ref",
],
comparison: Output,
},
],
changes: [
ChangeInfo {
old_subpath: "",
new_subpath: "",
message: "schema types changed",
class: Incompatible,
details: UnknownDifference,
},
],
},
]
2 changes: 1 addition & 1 deletion tests/cases/simple/output/ref-chain-change.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- "$ref": "#/components/schemas/SubType"
+ "$ref": "#/components/schemas/ErrorResponse"
},
"SubType": {
"SharedType": {
"properties": {


Expand Down
81 changes: 81 additions & 0 deletions tests/cases/simple/output/ref-vs-inline-type-change.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
--- ref-vs-inline-type-change.json
+++ patched
@@
]
},
"via_ref": {
- "$ref": "#/components/schemas/SubType"
+ "properties": {
+ "value": {
+ "type": "integer"
+ }
+ },
+ "type": "object"
}
},
"required": [
@@
"SubType": {
"properties": {
"value": {
- "type": "string"
+ "type": "integer"
}
},
"type": "object"


Result for patch:
[
Change {
paths: [
ChangePath {
old: [
"#/components/schemas/SubType/properties/value",
"#/components/schemas/GreetingResponse/properties/via_allof/0/$ref",
"#/paths/~1hello~1{name}/get/responses/200/content/application~1json/schema/$ref",
],
new: [
"#/components/schemas/SubType/properties/value",
"#/components/schemas/GreetingResponse/properties/via_allof/0/$ref",
"#/paths/~1hello~1{name}/get/responses/200/content/application~1json/schema/$ref",
],
comparison: Output,
},
],
changes: [
ChangeInfo {
old_subpath: "",
new_subpath: "",
message: "schema types changed",
class: Incompatible,
details: UnknownDifference,
},
],
},
Change {
paths: [
ChangePath {
old: [
"#/components/schemas/SubType/properties/value",
"#/components/schemas/GreetingResponse/properties/via_ref/$ref",
"#/paths/~1hello~1{name}/get/responses/200/content/application~1json/schema/$ref",
],
new: [
"#/components/schemas/GreetingResponse/properties/via_ref/properties/value",
"#/paths/~1hello~1{name}/get/responses/200/content/application~1json/schema/$ref",
],
comparison: Output,
},
],
changes: [
ChangeInfo {
old_subpath: "",
new_subpath: "",
message: "schema types changed",
class: Incompatible,
details: UnknownDifference,
},
],
},
]
2 changes: 1 addition & 1 deletion tests/cases/simple/output/schema-kind-type-to-oneof.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
--- schema-kind-type-to-oneof.json
+++ patched
@@
"$ref": "#/components/schemas/SubType"
"type": "object"
},
"SubType": {
- "properties": {
Expand Down
7 changes: 7 additions & 0 deletions tests/cases/simple/patch/input-output-schema-change.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[
{
"op": "replace",
"path": "/components/schemas/SharedType/properties/value/type",
"value": "integer"
}
]
19 changes: 19 additions & 0 deletions tests/cases/simple/patch/ref-vs-inline-type-change.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
[
{
"op": "replace",
"path": "/components/schemas/SubType/properties/value/type",
"value": "integer"
},
{
"op": "replace",
"path": "/components/schemas/GreetingResponse/properties/via_ref",
"value": {
"type": "object",
"properties": {
"value": {
"type": "integer"
}
}
}
}
]
Loading