Skip to content

fix(TrashIcon): Replace TrashIcon with RhUiTrashFillIcon#12510

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-trash-icon-with-rh-ui-trash-fill
Open

fix(TrashIcon): Replace TrashIcon with RhUiTrashFillIcon#12510
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-trash-icon-with-rh-ui-trash-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated icon components across documentation examples and demo components for visual consistency.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7269219-6304-4971-9b08-fff429d9f7de

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and da9458f.

📒 Files selected for processing (6)
  • packages/react-core/src/components/Form/examples/Form.md
  • packages/react-core/src/components/Form/examples/FormFieldGroups.tsx
  • packages/react-core/src/demos/CardView/CardView.md
  • packages/react-core/src/demos/CardView/examples/CardView.tsx
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailCardView.tsx

Walkthrough

Replaces TrashIcon with RhUiTrashFillIcon (from rh-ui-trash-fill-icon) across six files: the Form field groups example, CardView demo, and PrimaryDetail demo. Changes are limited to icon import statements and render sites; no logic, state, or props are altered.

Changes

Trash Icon Replacement

Layer / File(s) Summary
Form field group icon swap
packages/react-core/src/components/Form/examples/Form.md, packages/react-core/src/components/Form/examples/FormFieldGroups.tsx
Swaps the TrashIcon import for RhUiTrashFillIcon and updates all three "Remove" button render sites in the nested field groups.
CardView and PrimaryDetail demo icon swap
packages/react-core/src/demos/CardView/CardView.md, packages/react-core/src/demos/CardView/examples/CardView.tsx, packages/react-core/src/demos/PrimaryDetail.md, packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailCardView.tsx
Replaces TrashIcon import and delete dropdown render with RhUiTrashFillIcon in both the CardView and PrimaryDetailCardView demos, and updates corresponding .md import references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: replacing TrashIcon with RhUiTrashFillIcon across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants