Skip to content

fix(TrashIcon): Replace TrashIcon with RhUiTrashFillIcon #12510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(TrashIcon): Replace TrashIcon with RhUiTrashFillIcon #12510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Form/examples/Form.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ propComponents:
import { useRef, useEffect, useState } from 'react';
import RhUiErrorFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-error-fill-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import TrashIcon from '@patternfly/react-icons/dist/esm/icons/trash-icon';
import RhUiTrashFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-trash-fill-icon';
import styles from '@patternfly/react-styles/css/components/Form/form';

## Examples
Expand Down
8 changes: 4 additions & 4 deletions packages/react-core/src/components/Form/examples/FormFieldGroups.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
TextInput,
Button
} from '@patternfly/react-core';
import TrashIcon from '@patternfly/react-icons/dist/esm/icons/trash-icon';
import RhUiTrashFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-trash-fill-icon';

export const FormFieldGroups: React.FunctionComponent = () => {
const initialValues = {
Expand Down Expand Up @@ -75,7 +75,7 @@ export const FormFieldGroups: React.FunctionComponent = () => {
<FormFieldGroupHeader
titleText={{ text: 'Nested field group 1', id: 'nested-field-group1-titleText-id' }}
titleDescription="Nested field group 1 description text."
actions={<Button variant="plain" aria-label="Remove" icon={<TrashIcon />} />}
actions={<Button variant="plain" aria-label="Remove" icon={<RhUiTrashFillIcon />} />}
/>
}
>
Expand Down Expand Up @@ -104,7 +104,7 @@ export const FormFieldGroups: React.FunctionComponent = () => {
header={
<FormFieldGroupHeader
titleText={{ text: 'Nested field group 2', id: 'nested-field-group2-titleText-id' }}
actions={<Button variant="plain" aria-label="Remove" icon={<TrashIcon />} />}
actions={<Button variant="plain" aria-label="Remove" icon={<RhUiTrashFillIcon />} />}
/>
}
>
Expand Down Expand Up @@ -134,7 +134,7 @@ export const FormFieldGroups: React.FunctionComponent = () => {
<FormFieldGroupHeader
titleText={{ text: 'Nested field group 3', id: 'nested-field-group3-titleText-id' }}
titleDescription="Field group 3 description text."
actions={<Button variant="plain" aria-label="Remove" icon={<TrashIcon />} />}
actions={<Button variant="plain" aria-label="Remove" icon={<RhUiTrashFillIcon />} />}
/>
}
>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/CardView/CardView.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ section: patterns
---

import { Fragment, useState } from 'react';
import TrashIcon from '@patternfly/react-icons/dist/esm/icons/trash-icon';
import RhUiTrashFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-trash-fill-icon';
import RhUiAddCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-add-circle-fill-icon';
import pfIcon from '../assets/pf-logo-small.svg';
import activeMQIcon from '../assets/activemq-core_200x150.png';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/demos/CardView/examples/CardView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import {
SelectOption,
MenuToggleElement
} from '@patternfly/react-core';
import TrashIcon from '@patternfly/react-icons/dist/esm/icons/trash-icon';
import RhUiTrashFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-trash-fill-icon';
import RhUiAddCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-add-circle-fill-icon';
import pfIcon from './assets/pf-logo-small.svg';
import activeMQIcon from './assets/activemq-core_200x150.png';
Expand Down Expand Up @@ -529,7 +529,7 @@ export const CardViewBasic: React.FunctionComponent = () => {
deleteItem(product);
}}
>
<TrashIcon />
<RhUiTrashFillIcon />
Delete
</DropdownItem>
</DropdownList>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/PrimaryDetail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ section: patterns

import { Fragment, useState } from 'react';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import TrashIcon from '@patternfly/react-icons/dist/esm/icons/trash-icon';
import RhUiTrashFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-trash-fill-icon';
import RhUiCodeIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-code-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-check-circle-fill-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailCardView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import {
ToolbarContent,
MenuToggleElement
} from '@patternfly/react-core';
import TrashIcon from '@patternfly/react-icons/dist/esm/icons/trash-icon';
import RhUiTrashFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-trash-fill-icon';
import pfIcon from './assets/pf-logo-small.svg';
import activeMQIcon from './assets/activemq-core_200x150.png';
import avroIcon from './assets/camel-avro_200x150.png';
Expand Down Expand Up @@ -536,7 +536,7 @@ export const PrimaryDetailCardView: React.FunctionComponent = () => {
deleteItem(product);
}}
>
<TrashIcon />
<RhUiTrashFillIcon />
Delete
</DropdownItem>
</DropdownList>
Expand Down
Loading