fix(dataexchange): emit event on WriteFrame failure in handleConn (PILOT-184)#2
Merged
Merged
Conversation
…LOT-184)
When the ACK WriteFrame fails in handleConn, the loop silently
returns — no metric, event, or log is surfaced. Operators have
no visibility into ACK write failures on the wire.
Fix: emit s.deps.Events.Publish("dataexchange.ack_failed", ...)
with remote address, frame type, and error before returning.
Matches the existing event-emission pattern used by file.received
and message.received.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (PILOT-184)
When
handleConn's ACKWriteFramefails, the loop silently returns — no metric, event, or log is surfaced. Operators have zero visibility into ACK write failures on the wire.Fix
Emit
s.deps.Events.Publish("dataexchange.ack_failed", ...)with remote address, frame type, and error string before returning. Uses the same nil-guarded event-emission pattern already established byfile.receivedandmessage.receivedin this file.Scope
service.go:181-188—handleConnWriteFrame error pathVerification
🔗 PILOT-184