deps: switch shared types to common#3
Merged
Merged
Conversation
Mechanical sed sweep replacing every
github.com/TeoSlayer/pilotprotocol/pkg/{coreapi,protocol,driver,registry/client,registry/wire,config,logging,urlvalidate,secure}
and github.com/TeoSlayer/pilotprotocol/internal/ipcutil
with the equivalent github.com/pilot-protocol/common/<pkg>.
Adds a local replace directive so dev still resolves against the
local common checkout. The hub require for TeoSlayer/pilotprotocol
remains for now (handshake/runtime/libpilot keep their pkg/daemon
import; the rest will be cleaned up when web4 itself migrates in
Phase 3 — see common/extract-shared-types-from-web4 branch).
go build ./... passes.
TeoSlayer
added a commit
that referenced
this pull request
May 29, 2026
…ce path (#4) PR #3 ("deps: switch shared types from web4 hub to common") added `github.com/pilot-protocol/common` as an examples/go dependency with a `replace .. => ../../common` directive, but didn't update the CI workflow to actually check that sibling repo out. Result: every main CI run since #3 (2026-05-28T23:06) has failed at `go mod tidy` with: go: github.com/pilot-protocol/examples/go/client imports github.com/pilot-protocol/common/driver: github.com/pilot-protocol/common@v0.1.0: replacement directory ../../common does not exist Verified locally by reproducing the CI layout (examples + web4 + common checked out as siblings): tidy, build, and test all green. Closes PILOT-349. Co-authored-by: Teodor Calin <teodor@vulturelabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical migration: every
github.com/TeoSlayer/pilotprotocol/pkg/{coreapi,protocol,driver,registry/{client,wire},config,logging,urlvalidate,secure}import (and the previously-internalipcutil) is rewritten to use the canonicalgithub.com/pilot-protocol/common/<pkg>module.This is Phase 2 of the common-extraction migration. See
pilot-protocol/commonPR for Phase 1 (the actual package moves) andTeoSlayer/pilotprotocolPR for Phase 3 (web4 cleanup + duplicate deletion).Why
Today every sibling repo
requires theTeoSlayer/pilotprotocolhub for shared types. The hub in turnrequires every sibling for itscmd/daemonassembly. That's a locally-circular dep that only works because every repo hasreplace ... => ../web4for dev. At release time it forces coordinated tagging on every sibling+hub edit.Moving the shared types into
commonbreaks that cycle for the 13 leaf siblings (everything except handshake/runtime/libpilot which extend the daemon engine and stay tightly coupled topkg/daemon).What's in this PR
.gofile replacing 10 import paths.replace github.com/pilot-protocol/common => ../commonso local dev resolves against the local common checkout.go mod tidyclean.go build ./...passes.Merge order
This PR depends on the common-side PR (Phase 1) landing first so the new module paths actually resolve at the
common@vX.X.Xtag. Until then, localreplacekeeps everything working.🤖 Generated with Claude Code