Skip to content

fix(ci): checkout pilot-protocol/common so examples build resolves replace path (PILOT-349)#4

Merged
TeoSlayer merged 1 commit into
mainfrom
fix/ci-checkout-common-PILOT-349
May 29, 2026
Merged

fix(ci): checkout pilot-protocol/common so examples build resolves replace path (PILOT-349)#4
TeoSlayer merged 1 commit into
mainfrom
fix/ci-checkout-common-PILOT-349

Conversation

@TeoSlayer
Copy link
Copy Markdown
Contributor

Root cause: PR #3 (deps: switch shared types from web4 hub to common) added github.com/pilot-protocol/common as a dependency of examples/go via replace .. => ../../common, but didn't update .github/workflows/ci.yml to check that sibling out. Every main CI run since #3 has been red on go mod tidy (replacement directory ../../common does not exist).

Fix: add a Checkout common step before setup-go, mirroring the existing Checkout web4 pattern.

Verified locally — reproduced the CI layout (examples + web4 + common as siblings) and ran go mod tidy + go build ./... + go test ./..., all green.

Closes PILOT-349.

…ce path

PR #3 ("deps: switch shared types from web4 hub to common") added
`github.com/pilot-protocol/common` as an examples/go dependency with a
`replace .. => ../../common` directive, but didn't update the CI workflow
to actually check that sibling repo out. Result: every main CI run since
#3 (2026-05-28T23:06) has failed at `go mod tidy` with:

  go: github.com/pilot-protocol/examples/go/client imports
      github.com/pilot-protocol/common/driver:
      github.com/pilot-protocol/common@v0.1.0: replacement directory
      ../../common does not exist

Verified locally by reproducing the CI layout (examples + web4 + common
checked out as siblings): tidy, build, and test all green.

Closes PILOT-349.
@TeoSlayer TeoSlayer merged commit e2e2b7e into main May 29, 2026
4 checks passed
@TeoSlayer TeoSlayer deleted the fix/ci-checkout-common-PILOT-349 branch May 29, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants