tests: tighten coverage by retiring unreachable defensive code#2
Merged
Conversation
Two unreachable branches dropped:
1. ParseResponse (wire.go): the len(lines) == 0 guard cannot fire
because strings.Split always returns at least one element. The real
empty case is caught by the subsequent len(fields) < 1 check.
2. save (records.go): the json.MarshalIndent error branch cannot fire
on recordSnapshot — every field is a string, uint16, or time.Time,
no exotic types.
Left in place: the 60-second reapLoop ticker, the no-op
SetStorePath("") guard, and the MkdirAll/AtomicWrite error branches
(real filesystem failure modes worth keeping). Coverage 98.2% -> 99.0%.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unreachable branches dropped:
ParseResponse(wire.go): thelen(lines) == 0guard cannot fire becausestrings.Splitalways returns >= 1 element. The empty case is still caught by thelen(fields) < 1check.save(records.go):json.MarshalIndentcannot fail onrecordSnapshot— string/uint16/time.Time only.Left in place: 60-second
reapLoopticker body, theSetStorePath("")guard, and theMkdirAll/AtomicWriteerror branches (real filesystem failure modes worth keeping).Coverage
Test plan
go test -race -count=1 -timeout 120s ./...passes