Skip to content

tests: tighten coverage by retiring unreachable defensive code #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 1 commit into from
May 28, 2026
+7 −9
Merged

tests: tighten coverage by retiring unreachable defensive code #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions records.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,10 @@ func (rs *RecordStore) save() {
}
}

data, err := json.MarshalIndent(snap, "", " ")
if err != nil {
slog.Error("save nameserver state", "err", err)
return
}
// MarshalIndent on recordSnapshot is infallible: every field is a
// primitive (string/uint16) or time.Time, no exotic types.
// The error branch is unreachable.
data, _ := json.MarshalIndent(snap, "", " ")

dir := filepath.Dir(rs.storePath)
if err := os.MkdirAll(dir, 0700); err != nil {
Expand Down
7 changes: 3 additions & 4 deletions wire.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,10 @@ func FormatRequest(r Request) string {

// ParseResponse parses a plain-text nameserver response.
func ParseResponse(text string) (Response, error) {
// strings.Split always returns at least one element, so the
// "empty response" guard would be unreachable; the real empty
// case is caught by the len(fields) < 1 check below.
lines := strings.Split(strings.TrimSpace(text), "\n")
if len(lines) == 0 {
return Response{}, fmt.Errorf("empty response")
}

first := strings.TrimSpace(lines[0])
if first == "OK" {
return Response{Type: "OK"}, nil
Expand Down
Loading