-
Notifications
You must be signed in to change notification settings - Fork 648
remove primer_react_overlay_overflow FF from the codebase #7483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2330a0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the primer_react_overlay_overflow feature flag from the codebase. The feature flag was introduced in PR #5129 to enable responsive reflow behavior for the Overlay component, but was never rolled out to production. This is a cleanup operation that removes all references to the unused feature flag while preserving the existing default behavior.
Changes:
- Removed the
useFeatureFlagimport and feature flag check from Overlay component - Simplified the
data-reflow-containerattribute logic to only depend on thepreventOverflowprop - Removed the feature flag-specific test case
- Removed the feature flag definition from DefaultFeatureFlags
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/Overlay/Overlay.tsx | Removed useFeatureFlag import and simplified data-reflow-container logic to only check preventOverflow prop, maintaining the same behavior since the feature flag was never enabled |
| packages/react/src/Overlay/Overlay.test.tsx | Removed test case that verified behavior when feature flag was enabled |
| packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Removed primer_react_overlay_overflow feature flag definition |
TylerJDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ✨!
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/12055 |
|
Integration test results from github/github-ui:
CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
Relates to https://github.com/github/feature-flag-lifecycle/issues/5979
We ended up never rolling out this feature flag (introduced here #5129), so I'm cleaning it up.
Changelog
Removed
Rollout strategy
Testing & Reviewing
Merge checklist