Skip to content

Conversation

@francinelucca
Copy link
Member

Relates to https://github.com/github/feature-flag-lifecycle/issues/5979

We ended up never rolling out this feature flag (introduced here #5129), so I'm cleaning it up.

Changelog

Removed

  • all code references to primer_react_overlay_overflow FF

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings January 28, 2026 21:18
@francinelucca francinelucca requested a review from a team as a code owner January 28, 2026 21:18
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2026

🦋 Changeset detected

Latest commit: 2330a0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 28, 2026
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 28, 2026
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the primer_react_overlay_overflow feature flag from the codebase. The feature flag was introduced in PR #5129 to enable responsive reflow behavior for the Overlay component, but was never rolled out to production. This is a cleanup operation that removes all references to the unused feature flag while preserving the existing default behavior.

Changes:

  • Removed the useFeatureFlag import and feature flag check from Overlay component
  • Simplified the data-reflow-container attribute logic to only depend on the preventOverflow prop
  • Removed the feature flag-specific test case
  • Removed the feature flag definition from DefaultFeatureFlags

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/Overlay/Overlay.tsx Removed useFeatureFlag import and simplified data-reflow-container logic to only check preventOverflow prop, maintaining the same behavior since the feature flag was never enabled
packages/react/src/Overlay/Overlay.test.tsx Removed test case that verified behavior when feature flag was enabled
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Removed primer_react_overlay_overflow feature flag definition

Copy link
Member

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ✨!

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/12055

@primer-integration
Copy link

Integration test results from github/github-ui:

Failed  CI   Failed
Passed  VRT   Passed
Passed  Projects   Passed

CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures.

Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants