remove primer_react_overlay_overflow FF from the codebase

.changeset/flat-gifts-swim.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+remove primer_react_overlay_overflow FF from the codebase

packages/react/src/FeatureFlags/DefaultFeatureFlags.ts

@@ -3,7 +3,6 @@ import {FeatureFlagScope} from './FeatureFlagScope'
 export const DefaultFeatureFlags = FeatureFlagScope.create({
   primer_react_breadcrumbs_overflow_menu: false,
   primer_react_css_has_selector_perf: false,
-  primer_react_overlay_overflow: false,
   primer_react_select_panel_fullscreen_on_narrow: false,
   primer_react_select_panel_order_selected_at_top: false,
   primer_react_select_panel_remove_active_descendant: false,

packages/react/src/Overlay/Overlay.test.tsx

@@ -7,7 +7,6 @@ import Overlay from '../Overlay'
 import Text from '../Text'
 import BaseStyles from '../BaseStyles'
 import {NestedOverlays, MemexNestedOverlays, MemexIssueOverlay, PositionedOverlays} from './Overlay.features.stories'
-import {FeatureFlags} from '../FeatureFlags'
 import {implementsClassName} from '../utils/testing'
 import classes from './Overlay.module.css'
 
@@ -352,18 +351,4 @@ describe('Overlay', () => {
     const container = getByRole('dialog')
     expect(container).not.toHaveAttribute('data-reflow-container')
   })
-
-  it('should `data-reflow-container` if FF is enabled', async () => {
-    const user = userEvent.setup()
-    const {getByRole} = render(
-      <FeatureFlags flags={{primer_react_overlay_overflow: true}}>
-        <TestComponent />
-      </FeatureFlags>,
-    )
-
-    await user.click(getByRole('button', {name: 'open overlay'}))
-
-    const container = getByRole('dialog')
-    expect(container).toHaveAttribute('data-reflow-container')
-  })
 })

packages/react/src/Overlay/Overlay.tsx

@@ -8,7 +8,6 @@ import Portal from '../Portal'
 import {useRefObjectAsForwardedRef} from '../hooks/useRefObjectAsForwardedRef'
 import type {AnchorSide} from '@primer/behaviors'
 import type {ForwardRefComponent as PolymorphicForwardRefComponent} from '../utils/polymorphic'
-import {useFeatureFlag} from '../FeatureFlags'
 import classes from './Overlay.module.css'
 import {clsx} from 'clsx'
 
@@ -230,13 +229,12 @@ const Overlay = React.forwardRef<HTMLDivElement, internalOverlayProps>(
     // To be backwards compatible with the old Overlay, we need to set the left prop if x-position is not specified
     const leftPosition = left === undefined && right === undefined ? 0 : left
 
-    const overflowEnabled = useFeatureFlag('primer_react_overlay_overflow')
     return (
       <Portal containerName={portalContainerName}>
         <BaseOverlay
           role={role}
           width={width}
-          data-reflow-container={overflowEnabled || !preventOverflow ? true : undefined}
+          data-reflow-container={!preventOverflow ? true : undefined}
           ref={overlayRef}
           left={leftPosition}
           right={right}