fix: convert tint to RGBA array in _getTintedImageCanvas#8913
Open
BHARATH0153 wants to merge 1 commit into
Open
fix: convert tint to RGBA array in _getTintedImageCanvas#8913BHARATH0153 wants to merge 1 commit into
BHARATH0153 wants to merge 1 commit into
Conversation
Contributor
Author
|
@davepagurek @perminder-17 please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8910
Changes
tint()stores ap5.Colorobject but_getTintedImageCanvas()reads it as a plain array with numeric indices and.slice(). Ap5.Colorhas no numeric indices, sostates.tint[3]returnsundefined, givingctx.globalAlpha = NaNwhich the canvas ignores — tint appears as a no-op.convert the stored color to its RGBA array via
._arrayat the top of_getTintedImageCanvas()before using array operations.PR Checklist