Skip to content

fix: convert tint to RGBA array in _getTintedImageCanvas #8913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BHARATH0153 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

fix: convert tint to RGBA array in _getTintedImageCanvas #8913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/core/p5.Renderer2D.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,10 +444,12 @@ class Renderer2D extends Renderer {
ctx.save();
ctx.clearRect(0, 0, img.canvas.width, img.canvas.height);

const tint = this.states.tint._array || this.states.tint;

if (
this.states.tint[0] < 255 ||
this.states.tint[1] < 255 ||
this.states.tint[2] < 255
tint[0] < 255 ||
tint[1] < 255 ||
tint[2] < 255
) {
// Color tint: we need to use the multiply blend mode to change the colors.
// However, the canvas implementation of this destroys the alpha channel of
Expand All @@ -470,16 +472,16 @@ class Renderer2D extends Renderer {

// Apply color tint
ctx.globalCompositeOperation = 'multiply';
ctx.fillStyle = `rgb(${this.states.tint.slice(0, 3).join(', ')})`;
ctx.fillStyle = `rgb(${tint.slice(0, 3).join(', ')})`;
ctx.fillRect(0, 0, img.canvas.width, img.canvas.height);

// Replace the alpha channel with the original alpha * the alpha tint
ctx.globalCompositeOperation = 'destination-in';
ctx.globalAlpha = this.states.tint[3] / 255;
ctx.globalAlpha = tint[3] / 255;
ctx.drawImage(img.canvas, 0, 0);
} else {
// If we only need to change the alpha, we can skip all the extra work!
ctx.globalAlpha = this.states.tint[3] / 255;
ctx.globalAlpha = tint[3] / 255;
ctx.drawImage(img.canvas, 0, 0);
}

Expand Down