Conversation
|
Also I gotta mention the Python script is not pretty per se, but gets the job done |
pedro-psb
left a comment
pedro-psb
left a comment
There was a problem hiding this comment.
There are some linting errors.
I'm not sure if I'll have to allow the workflow again... I'll be watching
| version_str = match.group(1) | ||
| print("") | ||
| print("> [!NOTE]") | ||
| print(f"> Changes are also available on [Pulp docs](https://pulpproject.org/pulpcore/changes/#{version_str})") |
There was a problem hiding this comment.
This runs against all Pulp plugins, so you can't hardcode pulpcore here.
You can either make this script a template (.j2) and use {{ plugin_name }} or pass as an argument trough publish.yml.j2, which is already a template.
|
@StopMotionCuber I took the liberty to create another PR based on this one and add you as co-author: #1009 |
|
Oh sure. I'm sorry I didn't follow up on this one, but started this work when I was at cfgmgmtcamp, as it was a low hanging fruit, but then forgot about it afterwards when there was backlog from work. Thanks for following up on this one |
2 participants
This is a follow up of pulp/pulpcore#7279, with the suggestions from @pedro-psb applied here