Merged
Conversation
pedro-psb
force-pushed
the
clean-gh-release2
branch
from
9072e42 to
c9be81f
Compare
Contributor
StopMotionCuber
left a comment
StopMotionCuber
left a comment
There was a problem hiding this comment.
Thanks for picking this up, had an idea that would get rid of regex parsing. Though I have no strong opinions whether that should be pursued or not.
|
|
||
| def main(): | ||
| plugin_name = sys.argv[1] | ||
| version_str = "" |
Contributor
There was a problem hiding this comment.
Well, if we're going with sys.argv anyways, one could also think of executing
towncrier build --draft --version $TAG_NAME | .ci/scripts/clean_gh_release_notes.py {{ plugin_name }} $TAG_NAMEin the CI and get rid of regex parsing in favor of passing the version directly to the script
Though both versions would get the job done.
Member
Author
There was a problem hiding this comment.
I like obsoleting regexes
pedro-psb
force-pushed
the
clean-gh-release2
branch
from
c9be81f to
369898d
Compare
release_notes.md
Outdated
Contributor
There was a problem hiding this comment.
Has this file been added by accident? I guess this something for tests, which wasn't meant to be committed
The changelog generates markup intended for the documentation build enginee (mkdocs). For the github (or any markdown viwer), this pollutes the document. This adds a script to clean that up before publishing on github. Co-authored-by: Ruben Simons <r.simons@fz-juelich.de>
pedro-psb
force-pushed
the
clean-gh-release2
branch
from
369898d to
b603847
Compare
mdellweg
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog generates markup intended for the documentation build enginee (mkdocs). For the github (or any markdown viwer), this pollutes the document.
This adds a script to clean that up before publishing on github.
Continuation of the work of @StopMotionCuber : #1003