[BugFix] PolicyVersion: int64 dtype + preserve tensordict device#3755
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3755
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 3 Unrelated FailuresAs of commit 938b896 with merge base 0a01ee8 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 15, 2026
This was referenced May 15, 2026
This was referenced May 17, 2026
vmoens
added a commit
that referenced
this pull request
May 18, 2026
The integer branch was casting the version through ``float()`` and calling ``torch.full(shape, value)`` without a device, so the produced tensor was a CPU float tensor regardless of the surrounding tensordict. This broke any path that compared the version against an integer dtype or that lived on CUDA. Read the tensordict's device and pass ``dtype=torch.int64`` (with ``device`` only when the tensordict has one, since CPU tensordicts can have ``device=None``). Add a regression test pinning the dtype, shape, and device of the emitted ``policy_version`` tensor. ghstack-source-id: 66bea0a Pull-Request: #3755
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The integer branch was casting the version through
float()andcalling
torch.full(shape, value)without a device, so the producedtensor was a CPU float tensor regardless of the surrounding tensordict.
This broke any path that compared the version against an integer dtype
or that lived on CUDA.
Read the tensordict's device and pass
dtype=torch.int64(withdeviceonly when the tensordict has one, since CPU tensordicts canhave
device=None).Add a regression test pinning the dtype, shape, and device of the
emitted
policy_versiontensor.