[Doc] Migrate shifted=True callers to legacy/compact + docstring polish#3776
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3776
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 94e63df with merge base 5d11fa3 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 17, 2026
This was referenced May 18, 2026
vmoens
added a commit
that referenced
this pull request
May 18, 2026
- Switch benchmarks/test_objectives_benchmarks.py, examples/rlhf/utils.py and knowledge_base/ISAACLAB.md callers from the deprecated ``shifted=True`` to the explicit ``shifted="legacy"`` / ``shifted="compact"`` API. - Update data_layout.rst to mention the new shifted modes instead of ``single_call=True``. - Expand the ``compact_obs`` docstring on Collector to call out clean composition with ``GAE(shifted="compact")``. - Clarify in the GAE docstring how shifted="legacy", shifted="compact" and shifted=False differ in the recurrent-value-net case. - Clarify on MultiCollector that ``policy_version`` / ``get_policy_version`` expose only the parent-side tracker state; the per-frame ``"policy_version"`` tensor is the source of truth for collected data. - Minor formatting fix in examples/collectors/isaaclab_rnn_ppo_memory.py. Authored with Claude. Co-authored-by: Cursor <cursoragent@cursor.com> ghstack-source-id: 0b77cd5 Pull-Request: #3776
vmoens
added a commit
that referenced
this pull request
May 18, 2026
- Switch benchmarks/test_objectives_benchmarks.py, examples/rlhf/utils.py and knowledge_base/ISAACLAB.md callers from the deprecated ``shifted=True`` to the explicit ``shifted="legacy"`` / ``shifted="compact"`` API. - Update data_layout.rst to mention the new shifted modes instead of ``single_call=True``. - Expand the ``compact_obs`` docstring on Collector to call out clean composition with ``GAE(shifted="compact")``. - Clarify in the GAE docstring how shifted="legacy", shifted="compact" and shifted=False differ in the recurrent-value-net case. - Clarify on MultiCollector that ``policy_version`` / ``get_policy_version`` expose only the parent-side tracker state; the per-frame ``"policy_version"`` tensor is the source of truth for collected data. - Minor formatting fix in examples/collectors/isaaclab_rnn_ppo_memory.py. Authored with Claude. Co-authored-by: Cursor <cursoragent@cursor.com> ghstack-source-id: 2c3d60c Pull-Request: #3776
vmoens
added a commit
that referenced
this pull request
May 18, 2026
- Switch benchmarks/test_objectives_benchmarks.py, examples/rlhf/utils.py and knowledge_base/ISAACLAB.md callers from the deprecated ``shifted=True`` to the explicit ``shifted="legacy"`` / ``shifted="compact"`` API. - Update data_layout.rst to mention the new shifted modes instead of ``single_call=True``. - Expand the ``compact_obs`` docstring on Collector to call out clean composition with ``GAE(shifted="compact")``. - Clarify in the GAE docstring how shifted="legacy", shifted="compact" and shifted=False differ in the recurrent-value-net case. - Clarify on MultiCollector that ``policy_version`` / ``get_policy_version`` expose only the parent-side tracker state; the per-frame ``"policy_version"`` tensor is the source of truth for collected data. - Minor formatting fix in examples/collectors/isaaclab_rnn_ppo_memory.py. Authored with Claude. Co-authored-by: Cursor <cursoragent@cursor.com> ghstack-source-id: bf58ce4 Pull-Request: #3776
vmoens
added a commit
that referenced
this pull request
May 19, 2026
- Switch benchmarks/test_objectives_benchmarks.py, examples/rlhf/utils.py and knowledge_base/ISAACLAB.md callers from the deprecated ``shifted=True`` to the explicit ``shifted="legacy"`` / ``shifted="compact"`` API. - Update data_layout.rst to mention the new shifted modes instead of ``single_call=True``. - Expand the ``compact_obs`` docstring on Collector to call out clean composition with ``GAE(shifted="compact")``. - Clarify in the GAE docstring how shifted="legacy", shifted="compact" and shifted=False differ in the recurrent-value-net case. - Clarify on MultiCollector that ``policy_version`` / ``get_policy_version`` expose only the parent-side tracker state; the per-frame ``"policy_version"`` tensor is the source of truth for collected data. - Minor formatting fix in examples/collectors/isaaclab_rnn_ppo_memory.py. Authored with Claude. Co-authored-by: Cursor <cursoragent@cursor.com> ghstack-source-id: bf58ce4 Pull-Request: #3776
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
and knowledge_base/ISAACLAB.md callers from the deprecated
shifted=Trueto the explicitshifted="legacy"/shifted="compact"API.single_call=True.compact_obsdocstring on Collector to call out cleancomposition with
GAE(shifted="compact").and shifted=False differ in the recurrent-value-net case.
policy_version/get_policy_versionexpose only the parent-side tracker state; the per-frame
"policy_version"tensor is the source of truth for collected data.Authored with Claude.
Co-authored-by: Cursor cursoragent@cursor.com