chore: drop redundant aria-invalid / aria-required on Input & TextArea#815
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
aria-invalid/aria-requiredplumbing added toInputandTextAreain fix: a11y baseline pass across components #805 — both attributes were already being applied correctly.@base-ui/react/inputis justField.Controlunder the hood, andField.Controlauto-emitsaria-invalid="true"fromField.Root.invalidviagetInputValidationProps(). The ApsaraFieldRootalready passesinvalidinto<FieldPrimitive.Root>, so the explicitaria-invalid={resolvedInvalid}was a duplicate of what Base UI was emitting.TextAreaopts into the same Base UI behavior via<FieldPrimitive.Control render={textarea} />wheneverfieldContextis present, so it inherited the same redundancy.requiredattribute (already set viarequired={resolvedRequired}) carries the ARIA "required" semantic by itself; per WAI-ARIA,aria-requiredshouldn't be set on top of nativerequired. Also dropped theresolvedRequired || undefinedternary, which would have lost the ability to expressaria-required="false"explicitly.-8lines, no behavior change for screen readers — Base UI / native HTML continue to expose the same a11y contract.