Skip to content

chore: drop redundant aria-invalid / aria-required on Input & TextArea#815

Merged
rohanchkrabrty merged 1 commit into
mainfrom
chore-revert-input-textarea
May 19, 2026
Merged

chore: drop redundant aria-invalid / aria-required on Input & TextArea#815
rohanchkrabrty merged 1 commit into
mainfrom
chore-revert-input-textarea

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Revert the explicit aria-invalid / aria-required plumbing added to Input and TextArea in fix: a11y baseline pass across components #805 — both attributes were already being applied correctly.
  • @base-ui/react/input is just Field.Control under the hood, and Field.Control auto-emits aria-invalid="true" from Field.Root.invalid via getInputValidationProps(). The Apsara FieldRoot already passes invalid into <FieldPrimitive.Root>, so the explicit aria-invalid={resolvedInvalid} was a duplicate of what Base UI was emitting.
  • TextArea opts into the same Base UI behavior via <FieldPrimitive.Control render={textarea} /> whenever fieldContext is present, so it inherited the same redundancy.
  • The native HTML required attribute (already set via required={resolvedRequired}) carries the ARIA "required" semantic by itself; per WAI-ARIA, aria-required shouldn't be set on top of native required. Also dropped the resolvedRequired || undefined ternary, which would have lost the ability to express aria-required="false" explicitly.
  • Net effect: -8 lines, no behavior change for screen readers — Base UI / native HTML continue to expose the same a11y contract.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment May 19, 2026 5:59am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@rohanchkrabrty has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 6 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7734d660-c62b-4d27-a996-26e1dc361382

📥 Commits

Reviewing files that changed from the base of the PR and between 5b27e53 and 620bec7.

📒 Files selected for processing (2)
  • packages/raystack/components/input/input.tsx
  • packages/raystack/components/text-area/text-area.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty merged commit 4ca68ee into main May 19, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the chore-revert-input-textarea branch May 19, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants