Skip to content

chore: drop redundant aria-invalid / aria-required on Input & TextArea #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 1 commit into from
May 19, 2026
+0 −8
Merged

chore: drop redundant aria-invalid / aria-required on Input & TextArea #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/raystack/components/input/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,10 @@ export function Input({
containerRef,
classNames,
required,
'aria-invalid': ariaInvalid,
...props
}: InputProps) {
const fieldContext = useFieldContext();
const resolvedRequired = required ?? fieldContext?.required;
const resolvedInvalid = ariaInvalid ?? fieldContext?.invalid ?? undefined;

return (
<div
Expand Down Expand Up @@ -109,8 +107,6 @@ export function Input({
placeholder={chips?.length ? undefined : placeholder}
disabled={disabled}
required={resolvedRequired}
aria-invalid={resolvedInvalid}
aria-required={resolvedRequired || undefined}
{...props}
/>
</div>
Expand Down
4 changes: 0 additions & 4 deletions packages/raystack/components/text-area/text-area.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,10 @@ export function TextArea({
required,
size,
variant,
'aria-invalid': ariaInvalid,
...props
}: TextAreaProps) {
const fieldContext = useFieldContext();
const resolvedRequired = required ?? fieldContext?.required;
const resolvedInvalid = ariaInvalid ?? fieldContext?.invalid ?? undefined;

const handleChange = (event: ChangeEvent<HTMLTextAreaElement>) => {
onChange?.(event);
Expand All @@ -73,8 +71,6 @@ export function TextArea({
disabled={disabled}
placeholder={placeholder}
required={resolvedRequired}
aria-invalid={resolvedInvalid}
aria-required={resolvedRequired || undefined}
style={{ ...style, width }}
{...props}
/>
Expand Down
Loading