Conversation
|
Cursor Agent can help with this pull request. Just |
…tor form The Rill-managed ClickHouse path isn't working correctly because the work to create CH model files when OLAP is Rill-managed CH hasn't been completed yet. This change comments out the option to prevent customers from getting into a broken state, while preserving the code for easy re-enablement later. Changes: - Comment out rill-managed option in clickhouse.ts schema with TODO(APP-728) markers - Skip the Rill-managed ClickHouse test (can be re-enabled when feature is complete) Linear: APP-728 Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
cursor
bot
force-pushed
the
cursor/APP-728-rill-managed-ch-form-option-91a0
branch
from
9f710d1 to
845550c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 4
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| // TODO(APP-728): Re-enable when Rill-managed ClickHouse is ready | ||
| // properties: { | ||
| // managed: { const: false }, | ||
| // }, |
There was a problem hiding this comment.
Managed flag not reset for DSN
Medium Severity
In the self-managed + dsn branch, the then block no longer sets managed to false. Since managed still has a default of true, DSN-based self-managed connections can be emitted as managed, re-entering the hidden and incomplete Rill-managed path.
The Rill-managed ClickHouse path isn't working correctly because the
work to create CH model files when OLAP is Rill-managed CH hasn't been
completed yet. The option has already been removed from the enum in main.
This commit:
- Adds a TODO(APP-728) comment to document why rill-managed is removed from the enum
- Skips the Rill-managed ClickHouse test (can be re-enabled when feature is complete)
Note: The main branch already has rill-managed removed from the enum
and properly sets managed: { const: false } for all non-rill-managed paths.
Linear: APP-728
Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
cursor
bot
force-pushed
the
cursor/APP-728-rill-managed-ch-form-option-91a0
branch
from
8b9a17b to
2b0c935
Compare
|
ive already merged the PLAY PR which removes rill-managed CH i think we can close this! |
3 participants
Hides the Rill-managed ClickHouse option from the connector form.
WHY:
The Rill-managed ClickHouse feature is currently incomplete, lacking the functionality to create necessary model files. Hiding this option prevents users from encountering a broken path and ensures a stable experience until the feature is fully implemented.
WHAT:
web-common/src/features/templates/schemas/clickhouse.ts: Removed the "Rill-managed ClickHouse" radio button and all related schema fields and logic. The form now exclusively presents self-hosted ClickHouse connection options.web-local/tests/rill-yaml.spec.ts: Skipped the test case for Rill-managed ClickHouse, preserving the test code for future re-enablement.package-lock.json: Updated due to dependency resolution changes after runningnpm install.Checklist:
Linear Issue: APP-728
Note
Low Risk
UI/schema gating and a skipped test; no changes to core data processing or auth, with primary risk being unintended form/validation regressions for ClickHouse connection setup.
Overview
Hides the unfinished Rill-managed ClickHouse path from the ClickHouse connector schema by commenting out the
connector_typeradio and related visibility/validation branches, leaving only cloud/playground/self-managed connection flows exposed.Updates the Playwright coverage by skipping the
rill.yamldefaultolap_connector: clickhousetest that depends on the now-hidden Rill-managed option (kept for re-enablement under APP-728).Written by Cursor Bugbot for commit 8b9a17b. This will update automatically on new commits. Configure here.