Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web-common/src/features/templates/schemas/clickhouse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ export const clickhouseSchema: MultiStepFormSchema = {
deployment_type: {
type: "string",
title: "Connection type",
enum: ["cloud", "playground", "self-managed"], // removed rill-managed until SQL support is ready
// TODO(APP-728): Re-enable "rill-managed" option when CH model file creation is complete
enum: ["cloud", "playground", "self-managed"],
default: "cloud",
"x-display": "select",
"x-select-style": "rich",
Expand Down
28 changes: 28 additions & 0 deletions web-local/tests/rill-yaml.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,32 @@ test.describe("Default olap_connector behavior", () => {
await page.waitForURL("**/files/rill.yaml");
await expectRillYAMLToContainOlapConnector(page, "duckdb");
});

// Test skipped: Rill-managed ClickHouse option is temporarily hidden (APP-728)
// The feature isn't complete yet - it doesn't create CH model files when OLAP is Rill-managed CH
test.skip("Should set default olap_connector to clickhouse for Rill-managed ClickHouse", async ({
page,
}) => {
await page.getByRole("link", { name: "Empty Project" }).click();
await expect(page.getByText("Import data", { exact: true })).toBeVisible();

await page.getByRole("button", { name: "Add Data" }).click();
await page.locator("#clickhouse").click();
await page.getByRole("radio", { name: "Rill-managed ClickHouse" }).check();
await page
.getByRole("dialog", { name: "ClickHouse" })
.getByRole("button", {
name: "Connect",
exact: true,
})
.click();

// Wait for the connector file to be created in the file nav
await waitForFileNavEntry(page, "/connectors/clickhouse.yaml", false);

await page.getByRole("link", { name: "rill.yaml" }).click();
// Wait for navigation to complete
await page.waitForURL("**/files/rill.yaml");
await expectRillYAMLToContainOlapConnector(page, "clickhouse");
});
});
Loading