fix(cli-test)!: remove default "--app deployed" global flag from commands by srtaalej · Pull Request #2624 · slackapi/node-slack-sdk

srtaalej · 2026-06-10T18:14:02Z

Summary

Skip passing a default --app deployed flag to commands.

Notes

CLI commit c9f5bb in PR 565 motivates this change after introducing validation that rejects non-app-ID values (local, deployed) when using --app with create.

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

changeset-bot · 2026-06-10T18:14:11Z

🦋 Changeset detected

Latest commit: 16ed1ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@slack/cli-test	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2026-06-10T18:16:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.88%. Comparing base (65d23cb) to head (16ed1ef).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2624      +/-   ##
==========================================
- Coverage   88.88%   88.88%   -0.01%     
==========================================
  Files          62       62              
  Lines       10239    10238       -1     
  Branches      451      451              
==========================================
- Hits         9101     9100       -1     
- Misses       1116     1117       +1     
+ Partials       22       21       -1

Flag	Coverage Δ
cli-hooks	`88.88% <100.00%> (-0.01%)`	⬇️
cli-test	`88.88% <100.00%> (-0.01%)`	⬇️
logger	`88.88% <100.00%> (-0.01%)`	⬇️
oauth	`88.88% <100.00%> (-0.01%)`	⬇️
socket-mode	`88.88% <100.00%> (-0.01%)`	⬇️
web-api	`88.88% <100.00%> (-0.01%)`	⬇️
webhook	`88.88% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zimeg

@srtaalej LGTM for a quick fix but we should follow up with fewer defaults overall to avoid similar errors soon

zimeg

QQ before merge I might've tested just the current defaults

zimeg · 2026-06-10T18:40:27Z

-        cmd = cmd.concat(['--app', opts.app]);
-      } else {
-        cmd = cmd.concat(['--app', 'deployed']);
+      if (this.command[0] !== 'create') {


🦠 question: Oh does this block "app" flag from the "create" command altogetther?

yes i believe it does! should it only block when the flag is passed with local and deployed?

@srtaalej Hm I think we should remove app defaults altogether instead of extending the special cases to guard against. It's uncomfortable to add implementation logic to this package IMHO

sounds good 🚀

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

zimeg

🏁 @srtaalej A few suggestions and changes to the PR metadata to take this to a finished line. These changes are healthy for the package I think and I comment more on that too!

zimeg · 2026-06-10T22:37:45Z

        let cmd = new SlackCLIProcess(['help']);
        await cmd.execAsync();
+        sandbox.assert.neverCalledWith(spawnProcessSpy, sinon.match.string, sinon.match.array.contains(['--app']));


🧪 praise: Thanks for covering these cases!

zimeg · 2026-06-10T22:40:34Z

        cmd = cmd.concat(['--verbose']);
      }
    } else {
-      cmd = cmd.concat(['--skip-update', '--force', '--app', 'deployed']);


🪓 praise: Nice!

🔮 note: I have hope to split "force" into more meaningful flags and perhaps we use an environment variable to skip updates in later changes. I'm hoping we avoid having defaults exposed for each command.

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

test(cli-test): remove --app global flag from create command tests

51b65cc

srtaalej added this to the cli-test@next milestone Jun 10, 2026

srtaalej self-assigned this Jun 10, 2026

srtaalej requested a review from a team as a code owner June 10, 2026 18:14

srtaalej added semver:patch pkg:cli-test applies to `@slack/cli-test` labels Jun 10, 2026

zimeg added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Jun 10, 2026

zimeg changed the title ~~test(cli-test): remove --app global flag from create command tests~~ fix(cli-test): remove --app global flag from create command tests Jun 10, 2026

chore: chagneset

9c25b8e

zimeg changed the title ~~fix(cli-test): remove --app global flag from create command tests~~ fix(cli-test): remove default --app global flag from create command tests Jun 10, 2026

zimeg approved these changes Jun 10, 2026

View reviewed changes

Comment thread packages/cli-test/src/cli/cli-process.ts Outdated

zimeg reviewed Jun 10, 2026

View reviewed changes

srtaalej and others added 3 commits June 10, 2026 15:00

Update packages/cli-test/src/cli/cli-process.ts

978731a

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

remove app defaults and update test

8dda1e2

fix: lint formatting

95b50b2

srtaalej requested a review from zimeg June 10, 2026 20:45

zimeg added semver:major and removed semver:patch labels Jun 10, 2026

zimeg changed the title ~~fix(cli-test): remove default --app global flag from create command tests~~ fix(cli-test): remove default --app global flag from commands Jun 10, 2026

zimeg changed the title ~~fix(cli-test): remove default --app global flag from commands~~ fix(cli-test): remove default "--app deployed" global flag from commands Jun 10, 2026

zimeg changed the title ~~fix(cli-test): remove default "--app deployed" global flag from commands~~ fix(cli-test)!: remove default "--app deployed" global flag from commands Jun 10, 2026

zimeg approved these changes Jun 10, 2026

View reviewed changes

srtaalej and others added 3 commits June 11, 2026 10:52

Update .changeset/silver-papers-lick.md

593c88a

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

Update .changeset/silver-papers-lick.md

c625cbe

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

Update packages/cli-test/src/cli/cli-process.ts

16ed1ef

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

srtaalej merged commit e8fbfd5 into main Jun 11, 2026
12 checks passed

srtaalej deleted the ale-remove-app-flag-create branch June 11, 2026 16:14

Conversation

srtaalej commented Jun 10, 2026 • edited by zimeg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Requirements

Uh oh!

changeset-bot Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

srtaalej Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

srtaalej Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zimeg Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zimeg Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

srtaalej commented Jun 10, 2026 •

edited by zimeg

Loading

changeset-bot Bot commented Jun 10, 2026 •

edited

Loading

codecov Bot commented Jun 10, 2026 •

edited

Loading