Skip to content

fix(cli-test)!: remove default "--app deployed" global flag from commands #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srtaalej merged 8 commits into from
Jun 11, 2026
+29 −9
Merged

fix(cli-test)!: remove default "--app deployed" global flag from commands #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51b65cc
test(cli-test): remove --app global flag from create command tests
srtaalej Jun 10, 2026
9c25b8e
chore: chagneset
zimeg Jun 10, 2026
978731a
Update packages/cli-test/src/cli/cli-process.ts
srtaalej Jun 10, 2026
8dda1e2
remove app defaults and update test
srtaalej Jun 10, 2026
95b50b2
fix: lint formatting
srtaalej Jun 10, 2026
593c88a
Update .changeset/silver-papers-lick.md
srtaalej Jun 11, 2026
c625cbe
Update .changeset/silver-papers-lick.md
srtaalej Jun 11, 2026
16ed1ef
Update packages/cli-test/src/cli/cli-process.ts
srtaalej Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/silver-papers-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
"@slack/cli-test": major
---

fix: remove default "--app deployed" global flag from commands

Commands running for a specific app must now provide the "app" argument:

```diff
await SlackCLI.app.delete({
appPath: "my-app",
team: "T0123456789",
+ app: "deployed",
});
```

The options "local" or "deployed" or app ID all remain available to use.
14 changes: 9 additions & 5 deletions packages/cli-test/src/cli/cli-process.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,22 @@ describe('SlackCLIProcess class', () => {
await cmd.execAsync();
sandbox.assert.calledWith(spawnProcessSpy, sinon.match.string, sinon.match.array.contains(['--skip-update']));
});
it('should default to `--app deployed` but allow overriding that via the `app` parameter', async () => {
it('should only pass `--app` when explicitly provided via the `app` parameter', async () => {
let cmd = new SlackCLIProcess(['help']);
await cmd.execAsync();
sandbox.assert.neverCalledWith(spawnProcessSpy, sinon.match.string, sinon.match.array.contains(['--app']));
Comment on lines 102 to +104

@zimeg zimeg Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 praise: Thanks for covering these cases!

spawnProcessSpy.resetHistory();
cmd = new SlackCLIProcess(['help'], { app: 'local' });
await cmd.execAsync();
sandbox.assert.calledWith(spawnProcessSpy, sinon.match.string, sinon.match.array.contains(['--app', 'local']));
spawnProcessSpy.resetHistory();
cmd = new SlackCLIProcess(['help'], { app: 'deployed' });
await cmd.execAsync();
sandbox.assert.calledWith(
spawnProcessSpy,
sinon.match.string,
sinon.match.array.contains(['--app', 'deployed']),
);
spawnProcessSpy.resetHistory();
cmd = new SlackCLIProcess(['help'], { app: 'local' });
await cmd.execAsync();
sandbox.assert.calledWith(spawnProcessSpy, sinon.match.string, sinon.match.array.contains(['--app', 'local']));
});
it('should default to `--force` but allow overriding that via the `force` parameter', async () => {
let cmd = new SlackCLIProcess(['help']);
Expand Down
7 changes: 3 additions & 4 deletions packages/cli-test/src/cli/cli-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,9 @@ export class SlackCLIProcess {
if (opts.team) {
cmd = cmd.concat(['--team', opts.team]);
}
// App instance; defaults to `deployed`
// App instance
if (opts.app) {
cmd = cmd.concat(['--app', opts.app]);
} else {
cmd = cmd.concat(['--app', 'deployed']);
}
// Ignore warnings via --force; defaults to true
if (opts.force || typeof opts.force === 'undefined') {
Expand All @@ -149,9 +147,10 @@ export class SlackCLIProcess {
cmd = cmd.concat(['--verbose']);
}
} else {
cmd = cmd.concat(['--skip-update', '--force', '--app', 'deployed']);

@zimeg zimeg Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 praise: Nice!

🔮 note: I have hope to split "force" into more meaningful flags and perhaps we use an environment variable to skip updates in later changes. I'm hoping we avoid having defaults exposed for each command.

cmd = cmd.concat(['--skip-update', '--force']);
}
cmd = cmd.concat(this.command);

if (this.commandOptions) {
for (const [key, value] of Object.entries(this.commandOptions)) {
if (key && value) {
Expand Down
Loading