Skip to content

cre-4929: WorkflowActivationAbandoned#410

Open
mchain0 wants to merge 2 commits into
mainfrom
cre-4929
Open

cre-4929: WorkflowActivationAbandoned#410
mchain0 wants to merge 2 commits into
mainfrom
cre-4929

Conversation

@mchain0

@mchain0 mchain0 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@mchain0 mchain0 requested review from a team as code owners June 19, 2026 13:34
@changeset-bot

changeset-bot Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e20f905

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

👋 mchain0, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@mchain0 mchain0 mentioned this pull request Jun 19, 2026
Open
@github-actions

github-actions Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedJun 19, 2026, 1:37 PM

pavel-raykov
pavel-raykov reviewed Jun 19, 2026
View reviewed changes
Comment thread workflows/workflows/v2/workflow_activation_abandoned.proto
Workflow workflow = 2;
string timestamp = 3;
string errorMessage = 4;
string reason = 5; // "non_retryable" | "retry_limit_exceeded"

@pavel-raykov pavel-raykov Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not enum?

pavel-raykov
pavel-raykov reviewed Jun 19, 2026
View reviewed changes
Comment thread workflows/workflows/v2/workflow_activation_abandoned.proto
message WorkflowActivationAbandoned {
CreInfo creInfo = 1;
Workflow workflow = 2;
string timestamp = 3;

@pavel-raykov pavel-raykov Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why string? Should not we use int64 https://github.com/search?q=org%3Asmartcontractkit+timestamp+path%3A.proto&type=code ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavel-raykov pavel-raykov pavel-raykov left review comments

@ChrisAmora ChrisAmora Awaiting requested review from ChrisAmora

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mchain0 @pavel-raykov