Skip to content

cre-4929: retry limit and auto drop of failing workflows#22853

Open
mchain0 wants to merge 4 commits into
developfrom
cre-4929
Open

cre-4929: retry limit and auto drop of failing workflows#22853
mchain0 wants to merge 4 commits into
developfrom
cre-4929

Conversation

@mchain0

@mchain0 mchain0 commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

limit the number of retries and auto drop the failing workflows

required:

cre-4929

@mchain0 mchain0 requested review from a team as code owners June 16, 2026 12:00
@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

Tofel
Tofel reviewed Jun 16, 2026
View reviewed changes
Comment thread core/services/workflows/syncer/v2/workflow_registry.go
patrickhuie19
patrickhuie19 previously approved these changes Jun 16, 2026
View reviewed changes
@mchain0 mchain0 requested review from Tofel and patrickhuie19 June 16, 2026 14:28
patrickhuie19
patrickhuie19 previously approved these changes Jun 16, 2026
View reviewed changes
Tofel
Tofel previously approved these changes Jun 16, 2026
View reviewed changes
@mchain0 mchain0 dismissed stale reviews from Tofel and patrickhuie19 via 8abe150 June 19, 2026 13:31
@mchain0 mchain0 mentioned this pull request Jun 19, 2026
Open
@cl-sonarqube-production

cl-sonarqube-production Bot commented Jun 19, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
4 New issues
5 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 left review comments

@Tofel Tofel Tofel left review comments

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez

@kalverra kalverra Awaiting requested review from kalverra

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchain0 @patrickhuie19 @Tofel